From owner-freebsd-current@FreeBSD.ORG Mon Sep 9 21:40:33 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 894F75DF; Mon, 9 Sep 2013 21:40:33 +0000 (UTC) (envelope-from des@des.no) Received: from smtp.des.no (smtp.des.no [194.63.250.102]) by mx1.freebsd.org (Postfix) with ESMTP id 4CAA4264D; Mon, 9 Sep 2013 21:40:33 +0000 (UTC) Received: from nine.des.no (smtp.des.no [194.63.250.102]) by smtp-int.des.no (Postfix) with ESMTP id 56F314ECB; Mon, 9 Sep 2013 21:40:32 +0000 (UTC) Received: by nine.des.no (Postfix, from userid 1001) id 88F6E36101; Mon, 9 Sep 2013 23:40:02 +0200 (CEST) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: d@delphij.net Subject: Re: [PATCH] mtree should not output size if the file is not a regular file References: <522E3F06.3090003@delphij.net> Date: Mon, 09 Sep 2013 23:40:02 +0200 In-Reply-To: <522E3F06.3090003@delphij.net> (Xin Li's message of "Mon, 09 Sep 2013 14:35:02 -0700") Message-ID: <86bo41fzd9.fsf@nine.des.no> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: christos@NetBSD.org, FreeBSD Current , Brooks Davis , Tim Kientzle X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Sep 2013 21:40:33 -0000 Xin Li writes: > I think it doesn't make sense to emit size information for non-regular > files like directories, symlinks, etc. although both our and NetBSD's > mtree would emit it. I agree. The size of a directory will vary from filesystem to filesystem, while the size of a symlink is simply the length of its target. There is no need for it, and in the case of a directory, including it causes spurious diffs between mtree descriptions of identical trees on different systems. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no