Date: Sun, 5 Jun 2011 00:18:23 +0200 (CEST) From: Niclas Zeising <niclas.zeising@gmail.com> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/157618: [PATCH] fix broken configure script of x11-wm/fvwm2 Message-ID: <201106042218.p54MIN4A014630@vincent.daemonic.se> Resent-Message-ID: <201106042220.p54MK9x8039826@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 157618
>Category: ports
>Synopsis: [PATCH] fix broken configure script of x11-wm/fvwm2
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sat Jun 04 22:20:08 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator: Niclas Zeising
>Release: FreeBSD 8.2-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD vincent.daemonic.se 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Wed Apr 20 17:22:47 CEST 2011 root@vincent.daemonic.se:/usr/obj/usr/src/sys/VINCENT amd64
>Description:
The configure script supplied with the vendor sources for x11-wm/fvwm is broken and won't detect libXcursor if that is not located in ld's default path, which is (normally) the case in FreeBSD (where ports libs are in /usr/local/lib by default). This will not render in any error, and the port will install just fine, but it will not use libXcursor, even if it's present.
>How-To-Repeat:
>Fix:
The attached patch is a patch sent to and approved by the vendor. It is possible to use this patch to patch configure.ac and then use autoconf to generate a new configure script. Another option is to patch the configure script directly, or use some sort of REINPLACE in the makefile. I don't know what is the best course of action.
--- fvwm.configure.ac.diff begins here ---
Index: configure.ac
===================================================================
RCS file: /home/cvs/fvwm/fvwm/configure.ac,v
retrieving revision 1.69
diff -u -d -r1.69 configure.ac
--- configure.ac 16 Apr 2011 21:46:36 -0000 1.69
+++ configure.ac 4 Jun 2011 15:47:30 -0000
@@ -656,7 +656,7 @@
],[
with_xcursor=no
problem_xcursor=": Failed to detect libXcursor"
- ],)
+ ],[$X_LIBS $X_PRE_LIBS -lXext -lX11 $X_EXTRA_LIBS])
fi
AC_SUBST(Xcursor_CFLAGS)
AC_SUBST(Xcursor_LIBS)
--- fvwm.configure.ac.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201106042218.p54MIN4A014630>