From owner-freebsd-stable@FreeBSD.ORG Wed Aug 24 19:07:07 2011 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C5001106566B for ; Wed, 24 Aug 2011 19:07:07 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 6481A8FC0A for ; Wed, 24 Aug 2011 19:07:06 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id p7OJ73WO072245 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 24 Aug 2011 22:07:03 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4) with ESMTP id p7OJ73wN078683; Wed, 24 Aug 2011 22:07:03 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4/Submit) id p7OJ73l3078682; Wed, 24 Aug 2011 22:07:03 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 24 Aug 2011 22:07:03 +0300 From: Kostik Belousov To: Slawa Olhovchenkov Message-ID: <20110824190703.GY17489@deviant.kiev.zoral.com.ua> References: <20110824181907.GA48394@zxy.spb.ru> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="8hWk1bP476InP7gd" Content-Disposition: inline In-Reply-To: <20110824181907.GA48394@zxy.spb.ru> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-3.3 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, DNS_FROM_OPENWHOIS autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: freebsd-stable@freebsd.org Subject: Re: sigwait return 4 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Aug 2011 19:07:07 -0000 --8hWk1bP476InP7gd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 24, 2011 at 10:19:07PM +0400, Slawa Olhovchenkov wrote: > System is 8.2-RELEASE (GENERIC), amd64. > Application -- i386 for freebsd7. >=20 > In ktrace dump I find some strange result: >=20 > 22951 100556 kas-milter CALL sigwait(0xffdfdf80,0xffdfdf7c) > 22951 100556 kas-milter RET sigwait 4 > 22951 100556 kas-milter PSIG SIGUSR2 caught handler=3D0x804c0f0 mask=3D= 0x4003 code=3D0x0 >=20 > RET sigwait 4 confused me, and, I think, confused application too. >=20 > man sigwait: >=20 > ERRORS > The sigwait() system call will fail if: >=20 > [EINVAL] The set argument specifies one or more invalid si= gnal > numbers. >=20 > [EFAULT] Any arguments point outside the allocated address > space or there is a memory protection fault. >=20 >=20 > How sigwait can return '4'? > May be EINTR, converted from ERESTART? But kern_sigtimedwait from sigwait= must=20 > be called with timeout =3D=3D NULL... >=20 What should the system do for a delivered signal not present in the set ? I guess this is the case of your ktrace. Looking at the SUSv4, I see no mention of the situation, but in Oracle SunOS 5.10 man page for sigwait(2), it is said explicitely EINTR The wait was interrupted by an unblocked, caught signal. So I think that we have a bug in the man page. diff --git a/lib/libc/sys/sigwait.2 b/lib/libc/sys/sigwait.2 index 8c00cf4..b462201 100644 --- a/lib/libc/sys/sigwait.2 +++ b/lib/libc/sys/sigwait.2 @@ -27,7 +27,7 @@ .\" .\" $FreeBSD$ .\" -.Dd November 11, 2005 +.Dd August 24, 2011 .Dt SIGWAIT 2 .Os .Sh NAME @@ -94,6 +94,8 @@ The .Fn sigwait system call will fail if: .Bl -tag -width Er +.It Bq Er EINTR +The system call was interrupted by an unblocked, caught signal. .It Bq Er EINVAL The .Fa set --8hWk1bP476InP7gd Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEARECAAYFAk5VS9YACgkQC3+MBN1Mb4jiVACgr3FuAcrc2hblZhSSOh+uRgLB TysAoMcyZCl0Q1QZfFu5iPKnMMKUD01a =3+IN -----END PGP SIGNATURE----- --8hWk1bP476InP7gd--