From owner-freebsd-ports  Sat May 11  5:58:30 2002
Delivered-To: freebsd-ports@freebsd.org
Received: from sdns.kv.ukrtel.net (sdns.kv.ukrtel.net [195.5.27.246])
	by hub.freebsd.org (Postfix) with ESMTP
	id D839D37B404; Sat, 11 May 2002 05:58:24 -0700 (PDT)
Received: from vega.vega.com (195.5.51.243 [195.5.51.243]) by sdns.kv.ukrtel.net with SMTP (Microsoft Exchange Internet Mail Service Version 5.5.2650.21)
	id J9KHZL68; Sat, 11 May 2002 16:00:09 +0300
Received: from FreeBSD.org (big_brother.vega.com [192.168.1.1])
	by vega.vega.com (8.11.6/8.11.3) with ESMTP id g4BCwd163163;
	Sat, 11 May 2002 15:58:39 +0300 (EEST)
	(envelope-from sobomax@FreeBSD.org)
Message-ID: <3CDD1605.38B25E9D@FreeBSD.org>
Date: Sat, 11 May 2002 16:00:53 +0300
From: Maxim Sobolev <sobomax@FreeBSD.org>
Organization: Vega International Capital
X-Mailer: Mozilla 4.79 [en] (Windows NT 5.0; U)
X-Accept-Language: en,uk,ru
MIME-Version: 1.0
To: KOMATSU Shinichiro <koma2@jiro.c.u-tokyo.ac.jp>
Cc: freebsd-current@FreeBSD.ORG, ports@FreeBSD.ORG,
	Riccardo Torrini <riccardo@torrini.org>,
	Garrett Rooney <rooneg@electricjellyfish.net>
Subject: Re: bsd.port.mk dependency loop checking patch (Re: Who broke 'make 
 clean' for ports ?)
References: <XFMail.20020510190126.riccardo@torrini.org> <20020510172656.GD13627@dan.emsphone.com> <20020510173132.GA46688@electricjellyfish.net> <20020511090904.69E5B1949@taro.c.u-tokyo.ac.jp>
Content-Type: text/plain; charset=koi8-r
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-ports.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-ports>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-ports>
X-Loop: FreeBSD.org

KOMATSU Shinichiro wrote:
> 
> (add To: ports@freebsd.org)
> 
> From: Garrett Rooney <rooneg@electricjellyfish.net>
> Subject: Re: Who broke 'make clean' for ports ?
> Date: Sat, May 11, 2002 at 02:31:32AM JST
> 
> > there's a circular dependency that was just introduced to gettext.
> > gettext now depends on expat, which depends on gmake, which depends on
> > gettext.
> 
> Recently, I wrote a patch for bsd.port.mk that checks circular dependency.
> If a dependency loop is found, it gives you a warning and
> does not invoke 'make' process any further.
> 
> Someone, please test the patch below.
> If no problem is found, I will send-pr(8).

I don't think that we really need such patch. In 99.9999% of cases it
would just waste CPU cycles. Circular dependency is a bug and as such
it doesn't need to be a supported "special case".

-Maxim

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message