From owner-freebsd-net@FreeBSD.ORG  Fri Sep 16 19:40:14 2011
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E0478106566B;
	Fri, 16 Sep 2011 19:40:14 +0000 (UTC)
	(envelope-from pyunyh@gmail.com)
Received: from mail-yx0-f182.google.com (mail-yx0-f182.google.com
	[209.85.213.182])
	by mx1.freebsd.org (Postfix) with ESMTP id 890A68FC15;
	Fri, 16 Sep 2011 19:40:14 +0000 (UTC)
Received: by yxk36 with SMTP id 36so3934739yxk.13
	for <multiple recipients>; Fri, 16 Sep 2011 12:40:13 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=from:date:to:cc:subject:message-id:reply-to:references:mime-version
	:content-type:content-disposition:in-reply-to:user-agent;
	bh=88Fw5GjRbOEP39bE+ak6jAFHj2SAubCb71sOJ9qzKFg=;
	b=jnyZwsKVYwKmTNa/AdEa1Xs/JDafDIFJovFS0iuLXz9KTJ0LtBweU5TJcEQhUE0fNx
	wO0Pfu9oU7qXes+IoL/vHUCk8yGO0LJ6MqEJ5vEw8Vs1Ig+NjrgrxyIoyqICe4FxfPRB
	VI4mkYB/e+k5/F5dXKoXG7HWyHCI6N8UGutA4=
Received: by 10.68.29.5 with SMTP id f5mr1802606pbh.149.1316202013270;
	Fri, 16 Sep 2011 12:40:13 -0700 (PDT)
Received: from pyunyh@gmail.com ([174.35.1.224])
	by mx.google.com with ESMTPS id i8sm14268943pbl.2.2011.09.16.12.40.10
	(version=TLSv1/SSLv3 cipher=OTHER);
	Fri, 16 Sep 2011 12:40:12 -0700 (PDT)
Received: by pyunyh@gmail.com (sSMTP sendmail emulation);
	Fri, 16 Sep 2011 12:40:12 -0700
From: YongHyeon PYUN <pyunyh@gmail.com>
Date: Fri, 16 Sep 2011 12:40:12 -0700
To: Arnaud Lacombe <lacombar@gmail.com>
Message-ID: <20110916194012.GB9916@michelle.cdnetworks.com>
References: <CACqU3MWYa7awOO0x1jPNyXq2gccYAL+5wzkE6nOqsNGdP0GyeA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CACqU3MWYa7awOO0x1jPNyXq2gccYAL+5wzkE6nOqsNGdP0GyeA@mail.gmail.com>
User-Agent: Mutt/1.4.2.3i
Cc: freebsd-net@freebsd.org, FreeBSD-Current <freebsd-current@freebsd.org>
Subject: Re: Queue drop not accounted ?
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: pyunyh@gmail.com
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 16 Sep 2011 19:40:15 -0000

On Thu, Sep 15, 2011 at 09:25:19PM -0400, Arnaud Lacombe wrote:
> Hi,
> 
> Shouldn't packet freed in IFQ_ENQUEUE() because the queue is full be
> accounted as dropped, cf attached patch ?
> 

Hmm, I think err would be set to ENOBUFS for queue full case and
this err will crease ifq_drops.

> Thanks,
>  - Arnaud