From owner-cvs-src@FreeBSD.ORG Sun Jul 3 01:10:43 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.ORG Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C763B16A927; Sun, 3 Jul 2005 00:58:34 +0000 (GMT) (envelope-from ps@mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id E2A384468B; Sun, 3 Jul 2005 00:42:47 +0000 (GMT) (envelope-from ps@mu.org) Received: by elvis.mu.org (Postfix, from userid 1000) id 8F4696DCCD; Sat, 2 Jul 2005 17:38:10 -0700 (PDT) X-Original-To: ps@mu.org Delivered-To: ps@mu.org Received: from mx2.freebsd.org (mx2.freebsd.org [216.136.204.119]) by elvis.mu.org (Postfix) with ESMTP id 95B925C990 for ; Tue, 25 Jan 2005 03:28:06 -0800 (PST) Received: from hub.freebsd.org (hub.freebsd.org [216.136.204.18]) by mx2.freebsd.org (Postfix) with ESMTP id 9E1D25632A for ; Tue, 25 Jan 2005 11:26:26 +0000 (GMT) (envelope-from owner-src-committers@FreeBSD.org) Received: by hub.freebsd.org (Postfix) id 0A7E816A53F; Tue, 25 Jan 2005 11:26:21 +0000 (GMT) Delivered-To: ps@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 538) id 7EED416A4D1; Tue, 25 Jan 2005 11:26:18 +0000 (GMT) Delivered-To: src-committers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 92D8916A4CE; Tue, 25 Jan 2005 11:26:17 +0000 (GMT) Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id CE18F43D2D; Tue, 25 Jan 2005 11:26:16 +0000 (GMT) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.13.1/8.13.1) with ESMTP id j0PBQF8Z031258; Tue, 25 Jan 2005 14:26:15 +0300 (MSK) (envelope-from ache@nagual.pp.ru) Received: (from ache@localhost) by nagual.pp.ru (8.13.1/8.13.1/Submit) id j0PBQFU6031257; Tue, 25 Jan 2005 14:26:15 +0300 (MSK) (envelope-from ache) From: Andrey Chernov To: Poul-Henning Kamp Message-ID: <20050125112614.GD29791@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Poul-Henning Kamp , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <20050125110648.GB29791@nagual.pp.ru> <81636.1106651373@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <81636.1106651373@critter.freebsd.dk> User-Agent: Mutt/1.5.6i X-AntiVirus: checked by AntiVir Milter (version: 1.1.0-3; AVE: 6.29.0.8; VDF: 6.29.0.77; host: nagual.pp.ru) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-1.5.6 (nagual.pp.ru [0.0.0.0]); Tue, 25 Jan 2005 14:26:15 +0300 (MSK) Sender: owner-src-committers@FreeBSD.org Precedence: bulk X-Loop: FreeBSD.ORG X-Spam-Checker-Version: SpamAssassin 3.0.1 (2004-10-22) on elvis.mu.org X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.0.1 X-Spam-Level: Cc: cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern sys_generic.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Sun, 03 Jul 2005 01:10:44 -0000 X-Original-Date: Tue, 25 Jan 2005 14:26:14 +0300 X-List-Received-Date: Sun, 03 Jul 2005 01:10:44 -0000 On Tue, Jan 25, 2005 at 12:09:33PM +0100, Poul-Henning Kamp wrote: > >I.e. look at ERRORS section list and inspect each errno returning broken > >by preliminary zero bytes check. > > That's another check we didn't do before to the resid==0 handling before. > > Now, I'm going to killfile this subject until you come up with code which > real-life code which breaks because of this, OK ? I just show you the way of finding such cases, I already say I don't have much time to dig out real one. It is you who must prove that your addition not change anything or not violate POSIX. Because there is strong suspicion that you violates POSIX quote I already mention. I.e. look in the fo_read() chain and see which errors are skipped now. Even if you don't find such ones, it may simple mean that resid==0 check was placed preliminary in our old code, and it is old code which needs to be fixed. -- http://ache.pp.ru/