From owner-freebsd-net@FreeBSD.ORG Thu May 22 12:42:56 2008 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C08051065678 for ; Thu, 22 May 2008 12:42:56 +0000 (UTC) (envelope-from bms@FreeBSD.org) Received: from out1.smtp.messagingengine.com (out1.smtp.messagingengine.com [66.111.4.25]) by mx1.freebsd.org (Postfix) with ESMTP id 8CE8A8FC18 for ; Thu, 22 May 2008 12:42:56 +0000 (UTC) (envelope-from bms@FreeBSD.org) Received: from compute1.internal (compute1.internal [10.202.2.41]) by out1.messagingengine.com (Postfix) with ESMTP id 24A1210A66D; Thu, 22 May 2008 08:42:56 -0400 (EDT) Received: from heartbeat2.messagingengine.com ([10.202.2.161]) by compute1.internal (MEProxy); Thu, 22 May 2008 08:42:56 -0400 X-Sasl-enc: w5VJhvEEn/us4GCDfV00SMf47FcGncc3FazKdbC4sziA 1211460175 Received: from empiric.lon.incunabulum.net (82-35-112-254.cable.ubr07.dals.blueyonder.co.uk [82.35.112.254]) by mail.messagingengine.com (Postfix) with ESMTPSA id 75C1232A02; Thu, 22 May 2008 08:42:55 -0400 (EDT) Message-ID: <48356A4D.2050404@FreeBSD.org> Date: Thu, 22 May 2008 13:42:53 +0100 From: "Bruce M. Simpson" User-Agent: Thunderbird 2.0.0.14 (X11/20080514) MIME-Version: 1.0 To: Niki Denev References: <2e77fc10805211031n6c42ffd2u3dee28164094b83b@mail.gmail.com> <200805212332.13993.max@love2party.net> <2e77fc10805211514q59dd0eadkac2edce50d6c22f7@mail.gmail.com> <200805220041.24096.max@love2party.net> <2e77fc10805212057y7cbeca00kd096a7b090413616@mail.gmail.com> In-Reply-To: <2e77fc10805212057y7cbeca00kd096a7b090413616@mail.gmail.com> X-Enigmail-Version: 0.95.6 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Max Laier , freebsd-net@freebsd.org Subject: Re: lagg0.2 style vlans on lagg(4) interface X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 May 2008 12:42:56 -0000 Hi, It looks like this patch will cause gratuitous ARP to be queued even when the interface is not IFF_UP, is this intentional? Niki Denev wrote: > > I think arp_gratuit() needs a better name. > arp_announce() ? > Is if_ethersubr.c:ether_ifattach() good place to register the EVENT hook? > ARP is also used by FDDI and IEEE 802.5, as well as anything which emulates this. Taking the call to arp_ifinit() out of if_setlladdr() is likely to break this code. > And if yes, what would be the best way to handle failure to register > the hook, as the function is void? > > Should I worry about that, or just print a warning message and continue? > I see the C++-style comments - perhaps someone who knows event handlers better than I can comment, I believe it's using one of the shared kernel malloc pools with M_WAIT. It looks like this won't run afoul of locking, but it is a change to a fairly central path which needs to be considered carefully as it affects consumers other than Ethernet drivers. cheers BMS