From owner-freebsd-net@FreeBSD.ORG  Mon Jul  4 10:16:18 2005
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
X-Original-To: freebsd-net@freebsd.org
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3212916A41C
	for <freebsd-net@freebsd.org>; Mon,  4 Jul 2005 10:16:18 +0000 (GMT)
	(envelope-from demizu@dd.iij4u.or.jp)
Received: from r-dd.iij4u.or.jp (r-dd.iij4u.or.jp [210.130.0.70])
	by mx1.FreeBSD.org (Postfix) with ESMTP id AF69543D48
	for <freebsd-net@freebsd.org>; Mon,  4 Jul 2005 10:16:17 +0000 (GMT)
	(envelope-from demizu@dd.iij4u.or.jp)
Received: from localhost (h159.p048.iij4u.or.jp [210.130.48.159])
	by r-dd.iij4u.or.jp (4U-MR/r-dd) id j64AGCTb014033;
	Mon, 4 Jul 2005 19:16:13 +0900 (JST)
Date: Mon, 04 Jul 2005 19:15:37 +0900 (JST)
Message-Id: <20050704.191537.90127740.Noritoshi@Demizu.ORG>
From: Noritoshi Demizu <demizu@dd.iij4u.or.jp>
To: freebsd-net@freebsd.org
In-Reply-To: <20050415.143521.57443821.Noritoshi@Demizu.ORG>
References: <20050415.143521.57443821.Noritoshi@Demizu.ORG>
X-Mailer: Mew version 4.1 on Emacs 21 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Subject: Re: TCP MD5 Signature option handling in tcp_syncache.c
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Jul 2005 10:16:18 -0000

>   1. When the TCP MD5 Signature option is used on a TCP connection,
>      both the TCP Timestamps option and the TCP Window Scale option
>      are turned off.
>
>      I think the cause and the fix are as following:
>      At line 987 in tcp_syncache.c 1.70, sc->sc_flags is overwritten
>      by SCF_SIGNATURE.  By this line, SCF_TIMESTAMP and SCF_WINSCALE
>      are turned off.  I think the operator "=" should be "|=".
>
>  987: -		sc->sc_flags = SCF_SIGNATURE;
>  987: +		sc->sc_flags |= SCF_SIGNATURE;

I files this problem as kern/82963.

Regards,
Noritoshi Demizu