From owner-svn-src-head@freebsd.org  Sat Mar 25 23:36:38 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 569F2D1E00A;
 Sat, 25 Mar 2017 23:36:38 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id E249D1622;
 Sat, 25 Mar 2017 23:36:37 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from tom.home (kib@localhost [127.0.0.1])
 by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id v2PNaW0n075017
 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Sun, 26 Mar 2017 01:36:33 +0200 (EET)
 (envelope-from kostikbel@gmail.com)
DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua v2PNaW0n075017
Received: (from kostik@localhost)
 by tom.home (8.15.2/8.15.2/Submit) id v2PNaWuo075016;
 Sun, 26 Mar 2017 01:36:32 +0200 (EET)
 (envelope-from kostikbel@gmail.com)
X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com
 using -f
Date: Sun, 26 Mar 2017 01:36:32 +0200
From: Konstantin Belousov <kostikbel@gmail.com>
To: Dmitry Chagin <dchagin@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r315957 - in head/sys: amd64/linux amd64/linux32
 compat/linux i386/linux
Message-ID: <20170325233632.GI43712@kib.kiev.ua>
References: <201703251547.v2PFlUpf056924@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201703251547.v2PFlUpf056924@repo.freebsd.org>
User-Agent: Mutt/1.8.0 (2017-02-23)
X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00,
 DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no
 autolearn_force=no version=3.4.1
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 25 Mar 2017 23:36:38 -0000

On Sat, Mar 25, 2017 at 03:47:30PM +0000, Dmitry Chagin wrote:
> Author: dchagin
> Date: Sat Mar 25 15:47:29 2017
> New Revision: 315957
> URL: https://svnweb.freebsd.org/changeset/base/315957
> 
> Log:
>   Implement Linux mincore() system call.
>   This is necessary for the upcoming drm-next.
> +int
> +linux_mincore(struct thread *td, struct linux_mincore_args *args)
> +{
> +	struct mincore_args bsd_args;
> +
> +	/* Needs to be page-aligned */
> +	if (args->start & PAGE_MASK)
> +		return (EINVAL);
> +	bsd_args.addr = PTRIN(args->start);
> +	bsd_args.len = args->len;
> +	bsd_args.vec = args->vec;
> +	return (sys_mincore(td, &bsd_args));
> +}

Almost all syscalls implementations in vm/vm_mmap.c got the kern_*
helpers, sys_mincore() did not because it was not called outside the
file.  Please add kern_mincore() and use it, instead of abusing syscall
entry.