Date: Wed, 13 Aug 2014 17:41:49 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org>, Carlo Strub <cs@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org, vanilla@FreeBSD.org Subject: Re: svn commit: r364753 - in head/www/gatling: . files Message-ID: <0F2D6AC291CD1849F46DBCD4@ogg.in.absolight.net> In-Reply-To: <20140813152833.GA90841@FreeBSD.org> References: <201408130315.s7D3FWYs042556@svn.freebsd.org> <1407942463.639247.546514528.132749.2@c-st.net> <20140813152833.GA90841@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
+--On 13 ao=C3=BBt 2014 15:28:33 +0000 Alexey Dokuchaev <danfe@FreeBSD.org> wrote: | On Wed, Aug 13, 2014 at 05:07:43PM +0200, Carlo Strub wrote: |> 13/08/2014 05:16 - Vanilla I. Shu wrote: |> > New Revision: 364753 |> > URL: http://svnweb.freebsd.org/changeset/ports/364753 |> > QAT: https://qat.redports.org/buildarchive/r364753/ |> >=20 |> > [...] |> > -OPTIONS_DEFINE=3D BENCHMARKS SMB TLS ZLIB OPTIMIZED_CFLAGS |> > -OPTIONS_DEFAULT=3D BENCHMARKS SMB TLS ZLIB OPTIMIZED_CFLAGS |> > +OPTIONS_DEFINE=3D BENCHMARKS SMB TLS ZLIB OPTIMIZED_CFLAGS DOCS |> > EXAMPLES DEBUG +OPTIONS_SUB=3D yes |> > +OPTIONS_DEFAULT=3D BENCHMARKS SMB TLS ZLIB OPTIMIZED_CFLAGS DOCS |> > EXAMPLES |>=20 |> These large changes, especially the new options, merit a PORTREVISION |> bump, no? |=20 | No, why? Default options already include DOCS and EXAMPLES; the above | change in OPTIONS_DEFAULT is actually useless. OPTIONS_DEFAULT, yes, but they were not present in OPTIONS_DEFINE, thus were not there. There should have been a PORTREVISION bump with this change. --=20 Mathieu Arnold
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0F2D6AC291CD1849F46DBCD4>