From nobody Tue Dec 19 19:25:46 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SvmrD4lZxz54ml5 for ; Tue, 19 Dec 2023 19:25:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SvmrC6prnz3NL4 for ; Tue, 19 Dec 2023 19:25:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1703013948; a=rsa-sha256; cv=none; b=I4UDY0dzDctnA/0UKN4Y/p0VYhsLrbORqeXTviyDJsw62RQJIgp/+S32LlECg8EsRx/Xme dWABC728haMvLFqJstlTO+Jj0OhNjBZFk8/4l7/4Z62cjGbC/ouR00CyqJ0D1uHFZ2fJdI raECEyZqZQ0AJ/BYILXLG/p1fanLxX4XKgF8MA6bq3+K2gU40bhdEQKCINHIgT4Vue9mKG 8kuZOvh4ggXkuw6yo3gkNx0qVtHWx8xCuec57EwUjZ32SD4oaXuusuZMwpzwGdNdPtn7je sRmzEcTZWOfv/GXLnTEowpHspJ6X9tTiyA6QUN2rnYHJlNZfM/7emqMqn3qQUA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1703013948; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Nh1aEHeBqi4h9gjDP1kfUp7R4AR1X4GPdV4H8HCK100=; b=tlwpjslwcwgfBuI3eNtvCsqVIUbeNuhoQGR0BfS7fk+GeHyDm5gWA0gRjTzCTiotMEdhR3 bpqdImHY8mH/4kFZ/p/vBS3pMhXAhe2RqU/BTsbhHXbCIR1c+fUPEMav0FBa4mpk6FIyJm WsBAP+UZK0yQv8kLyXnZUrmHXt7o3sQtkmataMHBiSrGa+s67hE4l2ojnh+n8TwmzwB8HR MTL9QcY0CKB6YwQoi22DSjgzMSQAo04kGJKL6yQXvLNyqdttLXfFDZd+HCeqlDKmCcklSD 9uB1iAUfa9KUwFlRYfW8L9HjSHzGn1Hm+bjNJiMJbOhrwrzSae4DIXAfIKlWeg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SvmrC1QrGz3ML for ; Tue, 19 Dec 2023 19:25:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 3BJJPl1V074863 for ; Tue, 19 Dec 2023 19:25:47 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 3BJJPlKO074862 for bugs@FreeBSD.org; Tue, 19 Dec 2023 19:25:47 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 275169] Panic: rw_rlock: wlock already held for tcpinp @ /usr/src/sys/netinet/in_pcb.c:2529 Date: Tue, 19 Dec 2023 19:25:46 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.2-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D275169 --- Comment #28 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D513f2e2e7180202167ca2963d815d2a4c= 3ac0af9 commit 513f2e2e7180202167ca2963d815d2a4c3ac0af9 Author: Gleb Smirnoff AuthorDate: 2023-12-19 19:24:17 +0000 Commit: Gleb Smirnoff CommitDate: 2023-12-19 19:24:17 +0000 tcp: always set tcp_tun_port to a correct value The tcp_tun_port field that is used to pass port value between UDP and TCP in case of tunneling is a generic field that used to pass data between network layers. It can be contaminated on entry, e.g. by a VLAN tag set by a NIC driver. Explicily set it, so that it is zeroed out in a normal not-tunneled TCP. If it contains garbage, tcp_twcheck() later can enter wrong block of code and treat the packet as incorrectly tunneled one. On main and stable/14 that will end up with sending incorrect responses, but on stable/13 with ipfw(8) and pcb-matching rules it may end up in a panic. This is a minimal conservative patch to be merged to stable branches. Later we may redesign this. PR: 275169 Reviewed by: tuexen Differential Revision: https://reviews.freebsd.org/D43065 sys/netinet/tcp_input.c | 1 + 1 file changed, 1 insertion(+) --=20 You are receiving this mail because: You are the assignee for the bug.=