From owner-svn-ports-all@freebsd.org Wed Jul 1 15:16:07 2020 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8C5BD354D90; Wed, 1 Jul 2020 15:16:07 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49xlDR3Cqwz4cNw; Wed, 1 Jul 2020 15:16:07 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id 62A2513ACB; Wed, 1 Jul 2020 15:16:07 +0000 (UTC) Date: Wed, 1 Jul 2020 15:16:07 +0000 From: Alexey Dokuchaev To: Li-Wen Hsu Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r540967 - in head/net/lualdap: . files Message-ID: <20200701151607.GA6554@FreeBSD.org> References: <202007011406.061E6Cxt041119@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202007011406.061E6Cxt041119@repo.freebsd.org> X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jul 2020 15:16:07 -0000 On Wed, Jul 01, 2020 at 02:06:12PM +0000, Li-Wen Hsu wrote: > New Revision: 540967 > URL: https://svnweb.freebsd.org/changeset/ports/540967 > > Log: > Update to 1.2.5 > > ... > -MAKE_ARGS+= LUA_LIBDIR="${LUA_LIBDIR}" \ > - LUA_INC="${LUA_INCDIR}" \ > - OPENLDAP_LIB="-L${LOCALBASE}/lib -lldap" \ > - LUA_VERSION_NUM="${LUA_VER_STR}0" \ > - CC="${CC}" > +MAKE_ARGS+= CPPFLAGS="-I${LOCALBASE}/include -I${LUA_INCDIR}" \ > + LDFLAGS="-L${LOCALBASE}/lib" \ > + CC=${CC} Dropping quotes around ${CC} can potentially break things and also had contributed some unnecessary repo churn. :( ./danfe