From owner-freebsd-hackers@FreeBSD.ORG Sat May 28 16:33:11 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F05811065672; Sat, 28 May 2011 16:33:11 +0000 (UTC) (envelope-from inyaoo@gmail.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id 4A8D58FC15; Sat, 28 May 2011 16:33:10 +0000 (UTC) Received: by fxm11 with SMTP id 11so2642255fxm.13 for ; Sat, 28 May 2011 09:33:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=OdAP1NTgAiylZpv6hXVgYbovWDxShxEJbRRn8+WtRqE=; b=spG+wEeNiQ4+zSaFaEZ1xkqyAtiwRGkjR/+5gJptO7ekWIE3MDHrGa/XJhGIeZp3xi o86G/RP2d4FOefAJHH2bkSMDKcvGJWuycui4goMcRBQFroGt/AUa4AgIRdGDFujjG8fU 0Knznn+yUksYohlDsYY7Dp0JsjO4C/nBOod7w= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; b=OhmakvxrDIQ4qQj2yFd7duXIv6oSbA6Cr+c9CdQLu3lMKZ7U2lCywzZoS6KqeJG05+ 0eOWQQVLqT3w9ikZmIE3gTe5odSRzrmC1YurdXF8WwHy1s/+2hSGJZneZdaeRjK32TsC P/e41SGBEJbB5XjCxzvuN0FSRZave4YlPtNSc= Received: by 10.223.103.3 with SMTP id i3mr3637964fao.110.1306598894355; Sat, 28 May 2011 09:08:14 -0700 (PDT) Received: from localhost ([173.212.227.12]) by mx.google.com with ESMTPS id l26sm199140fah.14.2011.05.28.09.08.09 (version=SSLv3 cipher=OTHER); Sat, 28 May 2011 09:08:13 -0700 (PDT) From: Pan Tsu To: Alexander Best References: <20110527115147.GA73802@freebsd.org> <3BF63174-1B29-4A4D-96DD-3ED65ED96EAC@bsdimp.com> <20110527181459.GA29908@freebsd.org> <20110527182906.GA31871@freebsd.org> Date: Sat, 28 May 2011 20:08:05 +0400 In-Reply-To: <20110527182906.GA31871@freebsd.org> (Alexander Best's message of "Fri, 27 May 2011 18:29:06 +0000") Message-ID: <86oc2mlsey.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain Cc: freebsd-hackers@FreeBSD.ORG, freebsd-toolchain@FreeBSD.ORG Subject: Re: [rfc] a few kern.mk and bsd.sys.mk related changes X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 May 2011 16:33:12 -0000 Alexander Best writes: > On Fri May 27 11, Alexander Best wrote: >> On Fri May 27 11, Warner Losh wrote: >> > These look generally good. Just one thing I had a question on: >> > >> > # >> > +# Enable FreeBSD kernel-specific printf format specifiers. Also instruct gcc to >> > +# enable some diagnostics, which make it easier to pinpoint tinderbox failures. >> > +CFLAGS+= -fformat-extensions -fdiagnostics-show-option >> > + >> > >> > Does this put sand in the gears of clang support? > > i've improved the above comment so as to note that clang won't be affected by > -fdiagnostics-show-option. the new patch is available here: > > http://people.freebsd.org/~arundel/patches/kern.mk-bsy.sys.mk.patch > > another "issue" i've come across is the fact that on amd64, -O2 is always being > set, no matter, if debugging is enabled or disabled. i think amd64 should also > (just like all the other archs) be using -O, when debugging was enabled. Any reason a kernel with symbols (DEBUG) *must* be pessimized to -O1 level? Looking at r140606 it's not clear how symbols are related to a bump from -O1 to -O2 for non-amd64 archs. And -RELEASE kernels since at least 6.0R have `makeoptions DEBUG=-g' uncommented in GENERIC. > changing this is quite easy. so if people think this is something worth > changing i can integrate it into my existing patch.