From owner-svn-src-all@freebsd.org Thu Apr 19 15:21:52 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 42604F83617; Thu, 19 Apr 2018 15:21:52 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (unknown [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D1E446BA68; Thu, 19 Apr 2018 15:21:51 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-ua0-f181.google.com (mail-ua0-f181.google.com [209.85.217.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id B657F2075E; Thu, 19 Apr 2018 15:21:51 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-ua0-f181.google.com with SMTP id c3so3693545uae.2; Thu, 19 Apr 2018 08:21:51 -0700 (PDT) X-Gm-Message-State: ALQs6tAHaEFfN6a40KwE951S880BTYs45loFn/M18Hf5F6c1Gu7XvU6u G3O+ojE292DQBR+AehCufUm5re7PZiDNNavV+w4= X-Google-Smtp-Source: AIpwx4/fDkjCh+6XRaiGoYfwAG33eY7CLEz0JZDHHuV7wFShapMf/6OMSl5dsFcEH4GCAxd3/LZg98uuk9uuTrtDQPQ= X-Received: by 10.176.66.165 with SMTP id j34mr4941697uaj.65.1524151311344; Thu, 19 Apr 2018 08:21:51 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.54.12 with HTTP; Thu, 19 Apr 2018 08:21:30 -0700 (PDT) In-Reply-To: References: <201804191502.w3JF2sgQ051472@repo.freebsd.org> <201804191516.w3JFG99V066371@pdx.rh.CN85.dnsmgr.net> From: Kyle Evans Date: Thu, 19 Apr 2018 10:21:30 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r332773 - head/etc/rc.d To: Warner Losh Cc: "Rodney W. Grimes" , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Apr 2018 15:21:52 -0000 On Thu, Apr 19, 2018 at 10:19 AM, Warner Losh wrote: > > > On Thu, Apr 19, 2018 at 9:17 AM, Kyle Evans wrote: >> >> On Thu, Apr 19, 2018 at 10:16 AM, Rodney W. Grimes >> wrote: >> >> Author: kevans >> >> Date: Thu Apr 19 15:02:53 2018 >> >> New Revision: 332773 >> >> URL: https://svnweb.freebsd.org/changeset/base/332773 >> >> >> >> Log: >> >> Fix ddb rc script >> >> >> >> r288291 added a call to limits(1), which isn't available before >> >> partitions >> >> are mounted. This broke the ddb rc script, which does not provide its >> >> own >> >> start_cmd. >> >> >> >> Alleviate the situation here by providing a start_cmd. We still have >> >> other >> >> problems with diskless setups that need to be considered, but this is >> >> a >> >> start. >> > >> > Thanks, >> > Also didn't cy identify a second one of these? >> > Or am I confusing yet another issue? >> > >> >> He identified a second early script that didn't specify start_cmd, but >> it was a non-issue because it's invoked independently of rc.subr. > > > One would think that it shouldn't invoke limits at all if foo_limits= wasn't > specified... Would make the feature much less invasive. > foo_limits was introduced long after the initial invocation, which was introduced to enforce consistent limits of daemons run from rc.subr. Not doing this due to the lack of foo_flags would certainly kill the original intent, I'm afraid.