From owner-svn-src-head@FreeBSD.ORG Mon Jul 12 12:50:37 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 286291065678; Mon, 12 Jul 2010 12:50:37 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-bw0-f54.google.com (mail-bw0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id 1978D8FC1E; Mon, 12 Jul 2010 12:50:35 +0000 (UTC) Received: by bwz12 with SMTP id 12so2824779bwz.13 for ; Mon, 12 Jul 2010 05:50:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :x-enigmail-version:content-type:content-transfer-encoding; bh=XvmvLg82hu/t9tSb96NZqo4pfyMRT+uC3WN90NAO75E=; b=TuXGMbxkcLyzOY4mRjWtkwjH6yJVGEZFP/UGZQ+YXA0j96a93TPmqnZfekrorjiG1Q bUjlQnxfyuNjAAt7E6MmAB7pxAC9rUqPQgRpfV0mIyvtwdvKHghQQjcA0gKL0FGiaaJc sOKRoU/EFds3RbVxGoC6Z6vQrJkYxY1+SlI0g= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=uUSjVeEosZtBCTfbi4hgiEgOV2Gmf0At0lAYqtd8LhxvaThdvBq+OIUVed5rfjk93S zPPamg58g6BrlqpewmCFFpKb1I7xsHqFn+aVnHUXbMvUO/ggWJq1KOCKL01StcEyJ6ZK dNjBEBKTM+2mKOAc1PaqPUXr2qTc4WLhUYxEI= Received: by 10.204.84.17 with SMTP id h17mr2146460bkl.101.1278939034504; Mon, 12 Jul 2010 05:50:34 -0700 (PDT) Received: from mavbook2.mavhome.dp.ua (pc.mavhome.dp.ua [212.86.226.226]) by mx.google.com with ESMTPS id g11sm18388636bkw.10.2010.07.12.05.50.33 (version=SSLv3 cipher=RC4-MD5); Mon, 12 Jul 2010 05:50:33 -0700 (PDT) Sender: Alexander Motin Message-ID: <4C3B0F63.6000905@FreeBSD.org> Date: Mon, 12 Jul 2010 15:49:39 +0300 From: Alexander Motin User-Agent: Thunderbird 2.0.0.23 (X11/20091212) MIME-Version: 1.0 To: John Baldwin References: <201007111647.o6BGlk0O033551@svn.freebsd.org> <201007120813.19223.jhb@freebsd.org> In-Reply-To: <201007120813.19223.jhb@freebsd.org> X-Enigmail-Version: 0.96.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r209900 - head/sys/kern X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Jul 2010 12:50:37 -0000 John Baldwin wrote: > On Sunday, July 11, 2010 12:47:46 pm Alexander Motin wrote: >> Author: mav >> Date: Sun Jul 11 16:47:45 2010 >> New Revision: 209900 >> URL: http://svn.freebsd.org/changeset/base/209900 >> >> Log: >> Remove interval validation from cpu_tick_calibrate(). As I found, check >> was needed at preliminary version of the patch, where number of CPU ticks >> was divided strictly on 16 seconds. Final code instead uses real interval >> duration, so precise interval should not be important. Same time aliasing >> issues around second boundary causes false positives, periodically logging >> useless "t_delta ... too long/short" messages when HZ set below 256. > > Hmm, did you ask phk@ about this? Yes. He agreed that code should be reconsidered. > I notice that the printfs only trigger if > you have bootverbose enabled, so they were not affecting normal users as most > people do not run their systems with bootverbose enabled. Yes, but they produce major part of kernel messages on my own systems. I've got tired seeing them for years. It would be fine if they were usable, but, as I have told here and on current@, with preset implementation they were absolutely meaningless. -- Alexander Motin