From owner-svn-src-all@FreeBSD.ORG Fri Jun 19 13:40:45 2015 Return-Path: Delivered-To: svn-src-all@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9DDDF21A; Fri, 19 Jun 2015 13:40:45 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (mail.turbocat.net [IPv6:2a01:4f8:d16:4514::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5DEC3CE8; Fri, 19 Jun 2015 13:40:45 +0000 (UTC) (envelope-from hps@selasky.org) Received: from laptop015.home.selasky.org (cm-176.74.213.204.customer.telag.net [176.74.213.204]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 59C7B1FE023; Fri, 19 Jun 2015 15:40:13 +0200 (CEST) Message-ID: <55841BF3.8010205@selasky.org> Date: Fri, 19 Jun 2015 15:41:07 +0200 From: Hans Petter Selasky User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: David Chisnall CC: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r268137 - head/sys/sys References: <201407020845.s628jRG5031824@svn.freebsd.org> <5BE3492F-86A0-4CE3-A27C-8DB5EB662C64@FreeBSD.org> <5583F2C9.1030409@selasky.org> <1EB851FC-CA78-4A7B-BE5D-4F050C61A14C@FreeBSD.org> <558403C4.4040500@selasky.org> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jun 2015 13:40:45 -0000 On 06/19/15 14:54, David Chisnall wrote: > I definitely know of people building out-of-ports programs on FreeBSD whose code you have just broken (including myself, > though I do Objective-C stuff on 10, so haven’t yet encountered the breakage). Hi David, r268137 has been in 11-current for a long time (11 months) and was MFC'ed to 10-stable not long ago. Multiple systems are defining __weak for C and C++ : Linux: > include/linux/compiler-gcc.h: #define __weak __attribute__((weak)) NetBSD: > sys/cdefs_elf.h #define __weak __attribute__((__weak__)) FreeBSD: > sys/cdefs.h #define __weak __attribute__((__weak__)) __weak is *the* way currently to say __attribute__((__weak__)) in C and C++ cross multiple systems. Are you sure you want to change that? I understand that including "sys/cdefs.h" breaks objective C-code in the kernel, but we don't have any such code, do we? In userspace, why is objective C-code including "sys/cdefs.h"? Is this perhaps a mistake in another header file which indirectly includes "sys/cdefs.h" when it shouldn't? > Portable code should not rely on anything in cdefs.h. Right - can you explain why it is ending up in your ObjC code? And you are certain this is the change causing your build breakage? https://svnweb.freebsd.org/base?view=revision&revision=283326 Hope you bear with me, I just don't want to rush a fix. --HPS