From owner-cvs-all Fri Jan 31 20:54:31 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A647837B401; Fri, 31 Jan 2003 20:54:30 -0800 (PST) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3F86A43F93; Fri, 31 Jan 2003 20:54:30 -0800 (PST) (envelope-from baka@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1921) id 00CF1AE23A; Fri, 31 Jan 2003 20:54:29 -0800 (PST) Date: Fri, 31 Jan 2003 20:54:29 -0800 From: Jon Mini To: Scott Long Cc: Julian Elischer , John Baldwin , cvs-committers@freebsd.org, cvs-all@freebsd.org, "Tim J. Robbins" Subject: Re: cvs commit: src/sys/kern subr_trap.c Message-ID: <20030201045429.GS27470@elvis.mu.org> Mail-Followup-To: Scott Long , Julian Elischer , John Baldwin , cvs-committers@freebsd.org, cvs-all@freebsd.org, "Tim J. Robbins" References: <3E3AF6FD.4000904@btc.adaptec.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3E3AF6FD.4000904@btc.adaptec.com> User-Agent: Mutt/1.4i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Scott Long [scott_long@btc.adaptec.com] wrote : > Without picking on David, I think that this is a perfect example of the > grumbling that has been building about the lessening quality of people's > work. Would a forced backout send the message that untested and broken > commits are not acceptable? I'm reluctant to lower the axe while David > is away, but it's put us in a bad position. I also agree that this should be backed out, but I don't think it's core's place to do that in this situation. We have a much more appropriate (and less heavy-handed) move we can make, which still sends the right message but doesn't slag anyone in the process. Julian, how about you back it out? As David's mentor, this is entirely appropriate for you to do, especially since he's away. Say something in the commit message like "backing these changes out due to bugs discovered while david was on vacation. As his mentor, I am backing them out until he can fix them." -- Jonathan Mini http://www.freebsd.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message