From owner-freebsd-net@FreeBSD.ORG Thu Oct 29 07:40:04 2009 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6BCEE106566B for ; Thu, 29 Oct 2009 07:40:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 41A728FC18 for ; Thu, 29 Oct 2009 07:40:04 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n9T7e3oE003956 for ; Thu, 29 Oct 2009 07:40:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n9T7e3nj003955; Thu, 29 Oct 2009 07:40:03 GMT (envelope-from gnats) Date: Thu, 29 Oct 2009 07:40:03 GMT Message-Id: <200910290740.n9T7e3nj003955@freefall.freebsd.org> To: freebsd-net@FreeBSD.org From: Bernhard Schmidt Cc: Subject: Re: kern/140036: [iwn] [lor] lock order reversal with iwn0_com_lock and iwn0 softc lock X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Bernhard Schmidt List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Oct 2009 07:40:04 -0000 The following reply was made to PR kern/140036; it has been noted by GNATS. From: Bernhard Schmidt To: bug-followup@freebsd.org, kaduk@mit.edu Cc: Subject: Re: kern/140036: [iwn] [lor] lock order reversal with iwn0_com_lock and iwn0 softc lock Date: Thu, 29 Oct 2009 08:19:44 +0100 Hi, Removing the IWN_LOCK(sc) leads to races when calling iwn_cmd(). It's better to drop the IEEE80211_LOCK(ic). I do have a patch in test which hopefully will hit the tree soon. -- Bernhard