Date: Fri, 20 May 2016 00:28:47 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: Jan Beich <jbeich@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r415502 - head/devel/fb-adb Message-ID: <106A0892B19DF7E1043DD30C@atuin.in.mat.cc> In-Reply-To: <1t4y-owde-wny@vfemail.net> References: <201605191106.u4JB6CcI020057@repo.freebsd.org> <1t4y-owde-wny@vfemail.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--==========0A4C19B0C5A68A7D9348==========
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
+--On 19 mai 2016 18:17:33 +0200 Jan Beich <jbeich@FreeBSD.org> wrote:
| Mathieu Arnold <mat@FreeBSD.org> writes:
|
|> Modified: head/devel/fb-adb/Makefile
|> ========================================================================
|> ====== --- head/devel/fb-adb/Makefile Thu May 19 10:57:35 2016 (r415501)
|> +++ head/devel/fb-adb/Makefile Thu May 19 11:06:12 2016 (r415502) @@
|> -56,16 +56,17 @@ WRKSRC_ndk= ${ANDROID_NDK}
|> .else
|> NDK_DISTFILES= ${DISTNAME_ndk}.bin:ndk
|> DISTNAME_ndk= android-ndk-r10e-linux-${LINUX_RPM_ARCH:C/i.86/x86/}
|> +EXTRACT_ONLY= ${DISTFILES:N${EXTRACT_ONLY_7z}*}
|> +EXTRACT_ONLY_7z= ${DISTNAME_ndk}.bin
|> WRKSRC_ndk= ${WRKDIR}/${DISTNAME_ndk:C/(-[^-]+){2}$//}
|> .endif
|
| :N${FOO} syntax doesn't work with fmake i.e., on FreeBSD 9.x. Notice the
| port already handles similar case via .if defined(.PARSEDIR) conditional
| at the end.
True.
| Why unconditionally?
Because it doesn't hurt.
| If you didn't like my previous fix here's another
| one.
It's not so much I did not like it, it did not work.
--
Mathieu Arnold
--==========0A4C19B0C5A68A7D9348==========
Content-Type: application/pgp-signature
Content-Transfer-Encoding: 7bit
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQJ8BAEBCgBmBQJXPj4fXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz
QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85I5eAP+wUcPhJDmE5ueEKQKgJNYiaa
hRYkfzoodW5kT6OMcd6+/UEwyrnYvs/mfYfOFCK5yNiAVQ6Q2E5gI0cbgp1Sqlqm
JKbciSgGLLvan1ayJZ93C4KfIr1Vl8vqwriT8XRJ4jvM+gGjJgQIs+yVe+1QrMkx
RVnIpiFW4sJ0oD4dIETfvazufggAPqeBYBmP4PiJf9lRpuekzEwqORcLUIzXtUqU
FMowiHG18r2LBUZfPD928YLWa3BvJ/NwN9Pym/SyXVJltqf4jzcloEroV4w8Eq/O
kHve5awxM8PWHwSu2SNrVDf+Munfm3G9ByhlsADX/OGvhdusnsaW9QITMihqtZRu
zUK7XAOdZKhSTYyS2cLAHOkSUHsSaP6f+q1nCXxJb3kP6Tu8MnmGJGx/Z9aug7fh
zWeS2hbpYBGLycWRocfX91q5kQUr4837GxTWBOZETwpqebVLCBq5YDvcJ++5zptl
W2tQEOCCP2bsxRkpveUTP3K5En2b1AuRkdqu3JP55+kZB7YqyCgbm8rh4jdKl1AQ
Fv2fJZBhkhIFnn7dD0m4C9uXXuLslwd+Kl2I4nZOQW/b5r7zE6nsAQy/aYTT16BG
A1L0izvBnykIuPOmW0iT+Dtk67QE3sbGpMBa4GQoap65UtIZU2MzOsCkdOdiEwi5
uL3UOFKdhKTnwek+J9nf
=IoMw
-----END PGP SIGNATURE-----
--==========0A4C19B0C5A68A7D9348==========--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?106A0892B19DF7E1043DD30C>