Date: Sun, 5 Mar 2017 21:19:01 +0100 From: Ed Schouten <ed@nuxi.nl> To: "Conrad E. Meyer" <cem@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r314685 - head/bin/ps Message-ID: <CABh_MKkjZdOWm05Hi%2BkcNh_UNRoK=JF_MZdkzOhC912%2B=1aONA@mail.gmail.com> In-Reply-To: <CAG6CVpX_Q9JiW35Po7c4=TDSKy94%2BorFRSk_6u093T%2BbY2NL1Q@mail.gmail.com> References: <201703042238.v24McAD8008837@repo.freebsd.org> <CABh_MKnux-yfKhFeuApsZSNgyO1sktA_%2BDphhHQXaZezx92Cpw@mail.gmail.com> <CAG6CVpX_Q9JiW35Po7c4=TDSKy94%2BorFRSk_6u093T%2BbY2NL1Q@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Conrad,
2017-03-05 0:08 GMT+01:00 Conrad Meyer <cem@freebsd.org>:
>> - If something is a TTY, then our implementation of the TTY layer
>> guarantees that TIOCGWINSZ always works.
>
> Do you know if it did in 1990 too? It's hard to tell why Marc@ made
> this change way back then. I wasn't sure so I left it alone.
I can't tell. :-)
>> - If we're only interested in testing stdout whether it's a TTY, I
>> think it makes little sense to check TIOCGWINSZ on stdin, stderr.
>>
>> I think there would therefore be very little harm to use something like this:
>>
>> | if ((cols = getenv("COLUMNS")) != NULL && *cols != '\0')
>> | termwidth = atoi(cols);
>> | else if ((ioctl(STDOUT_FILENO, TIOCGWINSZ, (char *)&ws) ==
>> -1 && ws.ws_row == 0)
>
> Shouldn't this remain || ws.ws_row == 0?
Err, yes. ||, not &&.
--
Ed Schouten <ed@nuxi.nl>
Nuxi, 's-Hertogenbosch, the Netherlands
KvK-nr.: 62051717
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CABh_MKkjZdOWm05Hi%2BkcNh_UNRoK=JF_MZdkzOhC912%2B=1aONA>