From owner-freebsd-current Tue Jan 27 10:21:49 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id KAA04363 for current-outgoing; Tue, 27 Jan 1998 10:21:49 -0800 (PST) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from smtp02.primenet.com (smtp02.primenet.com [206.165.6.132]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id KAA04336 for ; Tue, 27 Jan 1998 10:21:39 -0800 (PST) (envelope-from tlambert@usr01.primenet.com) Received: (from daemon@localhost) by smtp02.primenet.com (8.8.8/8.8.8) id LAA27623; Tue, 27 Jan 1998 11:21:38 -0700 (MST) Received: from usr01.primenet.com(206.165.6.201) via SMTP by smtp02.primenet.com, id smtpd027503; Tue Jan 27 11:21:26 1998 Received: (from tlambert@localhost) by usr01.primenet.com (8.8.5/8.8.5) id LAA06880; Tue, 27 Jan 1998 11:21:20 -0700 (MST) From: Terry Lambert Message-Id: <199801271821.LAA06880@usr01.primenet.com> Subject: Re: PATCH: if_de.c #ifdef based version encoding To: dg@root.com Date: Tue, 27 Jan 1998 18:21:20 +0000 (GMT) Cc: tlambert@primenet.com, current@FreeBSD.ORG In-Reply-To: <199801271101.DAA25275@implode.root.com> from "David Greenman" at Jan 27, 98 03:01:07 am X-Mailer: ELM [version 2.4 PL25] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk > In theory, the de driver is maintained by Matt Thomas and he supports > multiple OS's and OS versions in the code. You'll notice that there are > #ifdef's for NetBSD and BSD/OS in there as well. If we were going to do > as you suggest, then it would only make sense if all of the OS #ifdef's > were removed. This will only make it more difficult for Matt to support > FreeBSD, so I think it's a bad idea. Is it at least possible to pick a symbol dependent on the version of the OS being compiled instead of the OS that the compiler doing the compiling was compiled on? Alternately, is it possible to modify the __FreeBSD__ symbol so that it gets the right value, perhaps overridable via sysctl or an environment variable so that you can build the next generation of FreeBSD kernels on the previous generation of the OS, and not need to rebuild tools with the only difference being the version number? Otherwise it's 6 more builds of GCC to be able to do one build of the kernel... and of course, you have to build the kernel for the new rev before doing the 3 builds of GCC that will have the new rev statically defined instead of the old rev. Thanks, Terry Lambert terry@lambert.org --- Any opinions in this posting are my own and not those of my present or previous employers.