From owner-svn-src-all@freebsd.org Wed Jan 20 20:03:26 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0E13FA89258; Wed, 20 Jan 2016 20:03:26 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-oi0-x22e.google.com (mail-oi0-x22e.google.com [IPv6:2607:f8b0:4003:c06::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C750617E2; Wed, 20 Jan 2016 20:03:25 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-oi0-x22e.google.com with SMTP id p187so12563916oia.2; Wed, 20 Jan 2016 12:03:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=JwVWBNvrwZneWKiuAp5c5FaUjAw3k3O4ROjE1MQDpTY=; b=eMVfDbOuJplOIe1Ry0bpXLwi7n3mPWaRXcHeKvSekpyAyMUDaxGyLlSAZc2r4MgPb/ JWWlOncXZIz+pDWztVRaT6eLEXbFgE+lxEF1PfQV6a8eGzBwAAKaqoF2v74BqmdyD1Tz xxNOJGWAxx1c9yRUqTl6pKG2FHueXRxeZvlaG20/QdVGelIaxM7oSvM+AdQ97q2gQEbi qWO9QLc2hTZrQN1t9xxMXraumpsDhf/vb2rHg1VAnotJLYtvEKrwS51AdkCVUp29uakp GEd5oRKwpyAhYaa1aIZjae0mwVjuHNDw61/F2VYhPcZZs9dASTCue7Sk8vdPtYhxJ47W yTlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=JwVWBNvrwZneWKiuAp5c5FaUjAw3k3O4ROjE1MQDpTY=; b=igMJB1Te6vMH1ewIS00+uGSIGBnkVuZSkwsLbnRLwxcvifFKSXHyB2J0HEsIyn0bP4 7QyfGvsOlKn/mfP/CXGDVQYhFqD457/xJlL3X2g1iwFqKiqxUnWV+OoyZkz5yJL4OV4E T6+dcmr4DjKyg2cRRNbOEmBBsIYev01ScHpP8FSpDmmOiKlT9oJ0tamZikIcCCVHm0h7 Vc37M/GEiqinVLeOR7Yx51g9KJvYDquuObUxQGjCRCgInBl74IPX5LcfsEBtqETBosrX 1XiPB5Pw/SnNj6g/mFQGa1MVq+F9Ez3VdFzoZMxR7AQjoD4TxtlKM2o1qIeKJrUh321Y yqXA== X-Gm-Message-State: ALoCoQmY78MQlBHVbMAv+kOVx9NdqZEBsFgUkivJGLW2SDb6UozUNl2jLrpNczRpkIDOMMNoKDsU37Tsb7Q6/9FaugKGD5HW7A== MIME-Version: 1.0 X-Received: by 10.202.177.193 with SMTP id a184mr26351882oif.86.1453320205036; Wed, 20 Jan 2016 12:03:25 -0800 (PST) Sender: asomers@gmail.com Received: by 10.202.69.84 with HTTP; Wed, 20 Jan 2016 12:03:24 -0800 (PST) In-Reply-To: <569F516D.80303@FreeBSD.org> References: <201601191700.u0JH0P6k061610@repo.freebsd.org> <569E6DA0.9010300@pix.net> <569F516D.80303@FreeBSD.org> Date: Wed, 20 Jan 2016 13:03:24 -0700 X-Google-Sender-Auth: sJ32uHfjGjBW87kBYccqVtJTV-8 Message-ID: Subject: Re: svn commit: r294329 - in head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs: . sys From: Alan Somers To: Andriy Gapon Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jan 2016 20:03:26 -0000 On Wed, Jan 20, 2016 at 2:20 AM, Andriy Gapon wrote: > On 19/01/2016 19:20, Alan Somers wrote: >> The thing is, it never really worked in the first place. Panics and >> deadlocks are so frequent that I don't think the feature was usable >> for anybody. > > The feature is perfectly usable for me. I have never run into the problems that > you describe. Why not fix the real bugs that you've run into? > > -- > Andriy Gapon Spectra Logic and iXSystems both experienced many problems with this. The worst is a deadlock that can be triggered simply by pulling a drive from a redundant pool when there exists a zvol anywhere in the system (see https://reviews.freebsd.org/D4998 for a quick way to reproduce). Fixing it correctly would likely require far more time than I have available. I just want the bugs to go away. See that same code review for a change to make the feature optional. -Alan