From owner-freebsd-current@FreeBSD.ORG Fri Aug 20 07:49:50 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8B9FA16A4CE; Fri, 20 Aug 2004 07:49:50 +0000 (GMT) Received: from mp2.macomnet.net (mp2.macomnet.net [195.128.64.6]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9EC9543D45; Fri, 20 Aug 2004 07:49:49 +0000 (GMT) (envelope-from maxim@macomnet.ru) Received-SPF: pass (mp2.macomnet.net: domain of maxim@macomnet.ru designates 127.0.0.1 as permitted sender) receiver=mp2.macomnet.net; client_ip=127.0.0.1; envelope-from=maxim@macomnet.ru; Received: from localhost (o2e59pbi@localhost [127.0.0.1]) by mp2.macomnet.net (8.12.11/8.12.11) with ESMTP id i7K7nhVi029002; Fri, 20 Aug 2004 11:49:43 +0400 (MSD) (envelope-from maxim@macomnet.ru) Date: Fri, 20 Aug 2004 11:49:43 +0400 (MSD) From: Maxim Konovalov To: Dan Nelson In-Reply-To: <20040813153607.GF4198@dan.emsphone.com> Message-ID: <20040820114001.R28976@mp2.macomnet.net> References: <200408131332.09164.ilkerozupak@yahoo.com> <20040813104934.GL87690@submonkey.net> <20040813153607.GF4198@dan.emsphone.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: Ceri Davies cc: Ilker Ozupak cc: des@freebsd.org cc: freebsd-current@freebsd.org Subject: Re: suid bit sshd X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Aug 2004 07:49:50 -0000 [ CC: DES, an author of rev. 1.19 secure/usr.bin/ssh/Makefile ] On Fri, 13 Aug 2004, 10:36-0500, Dan Nelson wrote: > In the last episode (Aug 13), Ilker Ozupak said: > > On Friday 13 August 2004 13:49, you wrote: > > > On Fri, Aug 13, 2004 at 01:31:52PM +0300, Ilker Ozupak wrote: > > > > sshd is not installed as setuid even make.conf modified according > > > > to docs. the fallowing output is just after install[kernel|world] > > > > and mergemaster > > > > > > > > > > > > [root@pascal]:/usr/src $ ls -l /usr/sbin/sshd > > > > - -r-xr-xr-x 1 root wheel 173480 Aug 13 12:24 /usr/sbin/sshd > > > > [root@pascal]:/usr/src $ grep SUID_SSH /etc/make.conf > > > > ENABLE_SUID_SSH= true > > > > > > That controls whether /usr/bin/ssh gets a setuid bit or not. You're > > > looking at the wrong binary. > > > > it is not setuid > > > > [root@pascal]:~ $ ls -l /usr/bin/ssh > > - -r-xr-xr-x 2 root wheel 95260 Aug 13 12:24 /usr/bin/ssh > > That's because rev 1.19 of secure/usr.bin/ssh/Makefile accidentally > removed the install code that checks for ENABLE_SUID_SSH. Apply this > patch and it will work again: Reading the comment log for 1.19 I can't say it was an accident. DES, is it OK to commit a following patch? Or you were going to deprecate ENABLE_SUID_SSH? We still have it in make.conf(5), share/examples/etc/make.conf and ssh-keysign/Makefile. > Index: /usr/src/secure/usr.bin/ssh/Makefile > =================================================================== > RCS file: /home/ncvs/src/secure/usr.bin/ssh/Makefile,v > retrieving revision 1.28 > diff -u -r1.28 Makefile > --- /usr/src/secure/usr.bin/ssh/Makefile 26 Feb 2004 11:26:46 -0000 1.28 > +++ /usr/src/secure/usr.bin/ssh/Makefile 2 Jun 2004 06:39:33 -0000 > @@ -2,6 +2,9 @@ > # > > PROG= ssh > +.if defined(ENABLE_SUID_SSH) > +BINMODE=4555 > +.endif > CFLAGS+=-I${SSHDIR} > LINKS= ${BINDIR}/ssh ${BINDIR}/slogin > MAN= ssh.1 ssh_config.5 > > > -- Maxim Konovalov