From owner-svn-ports-head@FreeBSD.ORG Tue Feb 4 20:10:33 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id DAC8E5AE; Tue, 4 Feb 2014 20:10:33 +0000 (UTC) Received: from mailrelay011.isp.belgacom.be (mailrelay011.isp.belgacom.be [195.238.6.178]) by mx1.freebsd.org (Postfix) with ESMTP id 0526C15D4; Tue, 4 Feb 2014 20:10:32 +0000 (UTC) X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AmEGAO9I8VJR8ZJI/2dsb2JhbABZgww4S74mgQ4XdIIlAQEFOhwjEAsOBgQJJQ8qHgaIHAEIzg8XjkIzB4Q4BJgqgTOQb4MuOw Received: from 72.146-241-81.adsl-dyn.isp.belgacom.be (HELO kalimero.tijl.coosemans.org) ([81.241.146.72]) by relay.skynet.be with ESMTP; 04 Feb 2014 21:10:01 +0100 Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org [127.0.0.1]) by kalimero.tijl.coosemans.org (8.14.7/8.14.7) with ESMTP id s14K9xDT021911; Tue, 4 Feb 2014 21:10:00 +0100 (CET) (envelope-from tijl@FreeBSD.org) Date: Tue, 4 Feb 2014 21:09:59 +0100 From: Tijl Coosemans To: Koop Mast Subject: Re: svn commit: r342587 - head/x11/pixman Message-ID: <20140204210959.044bc79a@kalimero.tijl.coosemans.org> In-Reply-To: <201402041839.s14IdgAF097754@svn.freebsd.org> References: <201402041839.s14IdgAF097754@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Feb 2014 20:10:33 -0000 On Tue, 4 Feb 2014 18:39:42 +0000 (UTC) Koop Mast wrote: > Author: kwm > Date: Tue Feb 4 18:39:42 2014 > New Revision: 342587 > URL: http://svnweb.freebsd.org/changeset/ports/342587 > QAT: https://qat.redports.org/buildarchive/r342587/ > > Log: > Fix SIMD check, and only check MACHINE_CPU if it is defined. > > Modified: > head/x11/pixman/Makefile > > Modified: head/x11/pixman/Makefile > ============================================================================== > --- head/x11/pixman/Makefile Tue Feb 4 18:35:58 2014 (r342586) > +++ head/x11/pixman/Makefile Tue Feb 4 18:39:42 2014 (r342587) > @@ -18,14 +18,16 @@ OPTIONS_DEFINE= SIMD > > .include > > -.if ! {PORT_OPTIONS:MSIMD} > +.if ! ${PORT_OPTIONS:MSIMD} > CONFIGURE_ARGS= --disable-vmx --disable-arm-simd > +. if defined(MACHINE_CPU) > . if ! ${MACHINE_CPU:Mmmx} > CONFIGURE_ARGS+= --disable-mmx > . endif > . if ! ${MACHINE_CPU:Msse2} > CONFIGURE_ARGS+= --disable-sse2 > . endif > +. endif > .endif > > .include The is a bit strange because if you turn off SIMD you still get MMX and SSE2 support if your cpu supports it. It should be something like this: .if ! ${PORT_OPTIONS:MSIMD} CONFIGURE_ARGS= --disable-vmx --disable-arm-simd --disable-mmx \ --disable-sse2 .endif But then you're still missing --disable-ssse3 and a number of ARM and MIPS SIMD options (reported by ./configure --help). I think it's best to just remove this whole block together with the SIMD option because pixman tests at runtime what features the cpu supports so in my opinion there's no reason to disable SIMD support. Or at the very least turn SIMD on by default. The current i386 package of pixman has SSSE3 support but not MMX or SSE2 which makes no sense: checking whether to use MMX intrinsics... disabled checking whether to use SSE2 intrinsics... disabled checking whether to use SSSE3 intrinsics... yes http://beefy1.isc.freebsd.org/bulk/head-i386-default/2014-01-23_09h31m52s/logs/pixman-0.32.4.log