From owner-svn-src-all@freebsd.org Sat Aug 22 14:37:01 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9A4A23BD3FA; Sat, 22 Aug 2020 14:37:01 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BYgvK3bYSz4jG8; Sat, 22 Aug 2020 14:37:01 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [IPv6:2001:470:7a58:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "Let's Encrypt Authority X3" (verified OK)) (Authenticated sender: dim) by smtp.freebsd.org (Postfix) with ESMTPSA id 4599316206; Sat, 22 Aug 2020 14:37:01 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from [IPv6:2001:470:7a58::b4b9:505e:3ee8:ae14] (unknown [IPv6:2001:470:7a58:0:b4b9:505e:3ee8:ae14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 58B95637EC; Sat, 22 Aug 2020 16:37:00 +0200 (CEST) From: Dimitry Andric Message-Id: <6014626A-854A-4120-8127-ABFA43C1713D@FreeBSD.org> Content-Type: multipart/signed; boundary="Apple-Mail=_28A1E023-75D2-4AB6-AE52-85C4EDD7411E"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.15\)) Subject: Re: svn commit: r364438 - in head/cddl: contrib/opensolaris/lib/libdtrace/common usr.sbin/dtrace/tests/tools Date: Sat, 22 Aug 2020 16:36:51 +0200 In-Reply-To: <20200822142736.GA57199@raichu> Cc: Antoine Brodin , src-committers , svn-src-all , svn-src-head@freebsd.org To: Mark Johnston References: <202008201928.07KJSJfP088877@repo.freebsd.org> <20200822142736.GA57199@raichu> X-Mailer: Apple Mail (2.3445.104.15) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Aug 2020 14:37:01 -0000 --Apple-Mail=_28A1E023-75D2-4AB6-AE52-85C4EDD7411E Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 22 Aug 2020, at 16:27, Mark Johnston wrote: >=20 > On Sat, Aug 22, 2020 at 12:40:49PM +0200, Antoine Brodin wrote: >> On Thu, Aug 20, 2020 at 9:28 PM Mark Johnston = wrote: >>>=20 >>> Author: markj >>> Date: Thu Aug 20 19:28:19 2020 >>> New Revision: 364438 >>> URL: https://svnweb.freebsd.org/changeset/base/364438 >>>=20 >>> Log: >>> Enable creation of static userspace probes in incremental builds. >>>=20 >>> To define USDT probes, dtrace -G makes use of relocations for = undefined >>> symbols: the target address is overwritten with NOPs and the = location is >>> recorded in the DOF section of the output object file. To avoid = link >>> errors, the original relocation is destroyed. However, this means = that >>> the same input object file cannot be processed multiple times, as >>> happens during incremental rebuilds. Instead, only set the = relocation >>> type to NONE, so that all information required to reconstruct USDT >>> probes is preserved. >>>=20 >>> Reported by: bdrewery >>> MFC after: 3 weeks >>> Sponsored by: The FreeBSD Foundation >>>=20 >>> Modified: >>> head/cddl/contrib/opensolaris/lib/libdtrace/common/dt_link.c >>> head/cddl/contrib/opensolaris/lib/libdtrace/common/dt_strtab.c >>> head/cddl/contrib/opensolaris/lib/libdtrace/common/dt_strtab.h >>> head/cddl/usr.sbin/dtrace/tests/tools/exclude.sh >>=20 >> Hi, >>=20 >> This change seems broken on i386: >>=20 >> = http://beefy17.nyi.freebsd.org/data/head-i386-default/p545731_s364466/logs= /perl5-devel-5.33.0.262.log >> = http://beefy17.nyi.freebsd.org/data/head-i386-default/p545731_s364466/logs= /perl5.28-5.28.3.log >> = http://beefy17.nyi.freebsd.org/data/head-i386-default/p545731_s364466/logs= /perl5.30-5.30.3.log >> = http://beefy17.nyi.freebsd.org/data/head-i386-default/p545731_s364466/logs= /perl5-5.32.0.log >=20 > The links are dead, but I think the problem should be fixed by = r364483. They work, but only over IPv6, unfortunately. :-) -Dimitry --Apple-Mail=_28A1E023-75D2-4AB6-AE52-85C4EDD7411E Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCX0EtgwAKCRCwXqMKLiCW o9peAJ4o0OlafWrUCKbNzauF6EUzrTUYkgCg7hLzn8xY9RQ4pcyPYjqGHWKX51I= =IkMl -----END PGP SIGNATURE----- --Apple-Mail=_28A1E023-75D2-4AB6-AE52-85C4EDD7411E--