From owner-freebsd-ports@FreeBSD.ORG Mon Nov 22 12:17:50 2010 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 01A0E106566B for ; Mon, 22 Nov 2010 12:17:50 +0000 (UTC) (envelope-from beech@akherb.com) Received: from bsdevel.akherb.com (bsdevel.akherb.com [208.86.224.193]) by mx1.freebsd.org (Postfix) with ESMTP id C93628FC12 for ; Mon, 22 Nov 2010 12:17:49 +0000 (UTC) Received: from pinnacle.akherb.com (180-150-42-72.gci.net [72.42.150.180]) by bsdevel.akherb.com (Postfix) with ESMTP id D9D801972F8F; Mon, 22 Nov 2010 12:17:48 +0000 (UTC) From: Beech Rintoul Organization: FreeBSD To: freebsd-ports@freebsd.org Date: Mon, 22 Nov 2010 03:17:47 -0900 User-Agent: KMail/1.13.5 (FreeBSD/8.1-STABLE; KDE/4.5.3; i386; ; ) References: <4CE7EC0D.9000203@a1poweruser.com> <201011211909.23708.beech@akherb.com> <20101122052649.GA61979@comcast.net> In-Reply-To: <20101122052649.GA61979@comcast.net> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201011220317.48090.beech@akherb.com> Cc: Charlie Kester Subject: Re: PR's not being picked up (Was Re: becoming a port committor) X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Nov 2010 12:17:50 -0000 On Sunday 21 November 2010 20:26:49 Charlie Kester wrote: > On Sun 21 Nov 2010 at 20:09:23 PST Beech Rintoul wrote: > >That is correct, although it is possible to use a unified diff with the > >"-N" flag against a non existent source. The problem is too many > >contributors send in update pr's in shar format which are a real PITA to > >deal with from our end. > > > >You may notice that many pr's aren't picked up by committers for just > >that reason. > > In such cases, does the submitter receive any communication explaining > the reasons his PR isn't getting worked on? > > E.g., why not send an email requesting resubmission in the proper > format? > > Many of the of oldest unassigned but still-open PR's show no evidence > that they've even been looked at by a committer. There are no entries > beyond the original one. How can we know which PR's were rejected/not > picked up for some reason and which ones were genuinely overlooked? You can't, but if a significant amount of time passes and no committer assigns themselves to a pr it usually means there are problems, either with the format or the upgrade itself. It's rare that a pr get's completely overlooked. We try and look at the list daily (as time permits). From: Contributing to the FreeBSD Ports Collection-5.2.1 Keep your ports up to date: 5. At some stage a committer will deal with your PR. It may take minutes, or it may take weeks - so please be patient. The reality is if a committer reviews a pr for an update and it's in shar format he/she will usually pass them by. If you think it's taking too long an email or question on #bsdports will usually get a response. We do get emails from portmgr detailing outstanding pr's, but there is no requirement to grab one. We also have a bugbusting team that reviews outstanding pr's and broken ports. With the wealth of info in The porter's guide and in contributing a submission which is coded well and in the proper format will usually get a quick response. Beech -- --------------------------------------------------------------------------------------- Beech Rintoul - FreeBSD Developer - beech@FreeBSD.org /"\ ASCII Ribbon Campaign | FreeBSD Since 4.x \ / - NO HTML/RTF in e-mail | http://people.freebsd.org/~beech X - NO Word docs in e-mail | Skype: akbeech / \ - http://www.FreeBSD.org/releases/8.0R/announce.html ---------------------------------------------------------------------------------------