From owner-freebsd-ports-bugs@freebsd.org Mon Nov 20 10:22:12 2017 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 842DBDE768B for ; Mon, 20 Nov 2017 10:22:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 70EEF78979 for ; Mon, 20 Nov 2017 10:22:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id vAKAMCav081565 for ; Mon, 20 Nov 2017 10:22:12 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 217555] New port: editors/kakoune Vim-inspired, selection-oriented code editor Date: Mon, 20 Nov 2017 10:22:12 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: tobik@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Nov 2017 10:22:12 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217555 Tobias Kortkamp changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tobik@freebsd.org --- Comment #2 from Tobias Kortkamp --- Hi, I don't know if this is still relevant, but here is a quick review. I'm sure the port could use an update to a newer commit too now :) XPORTVERSION=3D 0.0.1 ... XGH_TAGNAME=3D 8703f30 Please don't invent version numbers like this. If the project has no tagged release yet use a version with a date like g20171120. XLICENSE_NAME=3D UNLICENSE XLICENSE_PERMS=3D dist-mirror dist-sell pkg-mirror pkg-sell auto-accept These can go away. We have it in bsd.licenses.db.mk now. X.if (${OSVERSION} < 1100000) XBUILD_DEPENDS+=3D ${LOCALBASE}/bin/clang++38:lang/clang38 X XCXX=3D clang++38 X.endif Why is this necessary? X.include ... XUSES=3D gmake ncurses USES cannot be set after including bsd.port.pre.mk. It has no effect then. This is probably also why gmake was added to BUILD_DEPENDS manually. XDATADIR=3D ${PREFIX}/share/kak XDOCSDIR=3D ${PREFIX}/share/doc/kak Can the build be changed to install files into ${PREFIX}/share/kakoune instead? Xdo-build: X cd ${WRKSRC}/src && CXX=3D${CXX} ${GMAKE} && ${GMAKE} doc X cd ${WRKSRC}/doc && a2x --no-xmllint -f manpage kak.1.txt && ${GZIP_CMD} kak.1 This is wrong. To build something after the regular build a post-build target can be added and to build multiple targets ALL_TARGET=3D all doc To pass environment variables to gmake set MAKE_ENV. Xpost-install: X ${LN} -Fs rc ${STAGEDIR}${DATADIR}/autoload ${RLN} seems like a better choice here. Please confirm that it passes QA checks like poudriere testport and portlint too.=20 Thanks! --=20 You are receiving this mail because: You are the assignee for the bug.=