Date: Mon, 16 Nov 2015 02:08:42 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: John-Mark Gurney <jmg@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r290900 - head/sbin/restore Message-ID: <20151116020842.GA5488@FreeBSD.org> In-Reply-To: <201511160129.tAG1Tx0V080628@repo.freebsd.org> References: <201511160129.tAG1Tx0V080628@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Nov 16, 2015 at 01:29:59AM +0000, John-Mark Gurney wrote: > New Revision: 290900 > URL: https://svnweb.freebsd.org/changeset/base/290900 > > Log: > If you backup a large file that is mostly holes, previously we'd issue > a seek for every block... For large (Exabyte sized files) this would > issue lots of unneeded seeks, so combine them... > > [...] > @@ -938,14 +953,15 @@ getfile(void (*datafill)(char *, long), > { > int i; > off_t size; > + long seekpos; Briefly reading through tape.c, it looks like `long' is abused here (and in other places). IMHO we should try to fix these bugs, not add new misuses. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20151116020842.GA5488>