From owner-freebsd-arch@FreeBSD.ORG  Tue Jan 10 20:36:28 2012
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: freebsd-arch@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 602E1106566B
	for <freebsd-arch@freebsd.org>; Tue, 10 Jan 2012 20:36:28 +0000 (UTC)
	(envelope-from to.my.trociny@gmail.com)
Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com
	[209.85.214.54])
	by mx1.freebsd.org (Postfix) with ESMTP id E19D58FC08
	for <freebsd-arch@freebsd.org>; Tue, 10 Jan 2012 20:36:27 +0000 (UTC)
Received: by bkbzs2 with SMTP id zs2so862660bkb.13
	for <freebsd-arch@freebsd.org>; Tue, 10 Jan 2012 12:36:26 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=from:to:cc:subject:references:x-comment-to:sender:date:in-reply-to
	:message-id:user-agent:mime-version:content-type;
	bh=X9Og+FMUhNglCfVGU8JDm2bxiF2jXwSZwcoDf359JKQ=;
	b=TCh/V6qkj8WumBCrzFcOhZqQr2Yj4RTRCISJWd29k2sy0O9QScuHK+o23LaUmiJsEu
	nY+KmvH01SLDkiO/jylT2/SbvFao/5qwaWand8XT8LWMnSKsR5dlKLOpo3cVkNYjh3I9
	J3dEDoKb+3mW1y3sT0bFkRfX2PgFOppMZuAQQ=
Received: by 10.204.153.211 with SMTP id l19mr9311425bkw.24.1326226221425;
	Tue, 10 Jan 2012 12:10:21 -0800 (PST)
Received: from localhost ([95.69.173.122])
	by mx.google.com with ESMTPS id y22sm84131292bkf.4.2012.01.10.12.10.17
	(version=TLSv1/SSLv3 cipher=OTHER);
	Tue, 10 Jan 2012 12:10:18 -0800 (PST)
From: Mikolaj Golub <trociny@freebsd.org>
To: John Baldwin <jhb@freebsd.org>
References: <86sjjobzmn.fsf@kopusha.home.net>
	<201201100819.18892.jhb@freebsd.org>
X-Comment-To: John Baldwin
Sender: Mikolaj Golub <to.my.trociny@gmail.com>
Date: Tue, 10 Jan 2012 22:10:15 +0200
In-Reply-To: <201201100819.18892.jhb@freebsd.org> (John Baldwin's message of
	"Tue, 10 Jan 2012 08:19:18 -0500")
Message-ID: <86hb03tj2w.fsf@kopusha.home.net>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Kostik Belousov <kib@freebsd.org>, Robert Watson <rwatson@freebsd.org>,
	freebsd-arch@freebsd.org
Subject: Re: unix domain sockets on nullfs(5)
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Jan 2012 20:36:28 -0000


On Tue, 10 Jan 2012 08:19:18 -0500 John Baldwin wrote:

 JB> I think this is a decent solution.  Why not make the locking notes for 
 JB> VOP_UNPCONNECT() be "L" instead of "E"?  A read lock should be sufficient
 JB> to fetch the socket?  In fact, I suspect that unp_connect() could actually
 JB> use a shared lock on the vnode by adding 'LOCKSHARE' to the flags passed
 JB> to namei() via NDINIT().

This looks reasonable to me. I am going to modify the patch accordingly. Thanks.

-- 
Mikolaj Golub