From owner-cvs-all Thu Oct 24 13:42:15 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9D0B237B401; Thu, 24 Oct 2002 13:42:14 -0700 (PDT) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4C6C643E77; Thu, 24 Oct 2002 13:42:13 -0700 (PDT) (envelope-from robert@fledge.watson.org) Received: from fledge.watson.org (fledge.pr.watson.org [192.0.2.3]) by fledge.watson.org (8.12.4/8.12.4) with SMTP id g9OKfPOo064522; Thu, 24 Oct 2002 16:41:26 -0400 (EDT) (envelope-from robert@fledge.watson.org) Date: Thu, 24 Oct 2002 16:41:24 -0400 (EDT) From: Robert Watson X-Sender: robert@fledge.watson.org To: Juli Mallett Cc: Mark Valentine , "\"Sam Leffler\"" , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/make var.c In-Reply-To: <20021024133909.A85410@FreeBSD.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, 24 Oct 2002, Juli Mallett wrote: > * De: Mark Valentine [ Data: 2002-10-24 ] > [ Subjecte: Re: cvs commit: src/usr.bin/make var.c ] > > > From: sam@errno.com ("Sam Leffler") > > > Date: Thu 24 Oct, 2002 > > > Subject: Re: cvs commit: src/usr.bin/make var.c > > > > > Juli, this breaks make in groff/tmac (looks like the $f var sub is not done > > > right). Please back it out for now. > > > > Looks like Juli transposed var[1] into val[1]... (Just checked the OpenBSD > > code.) > > Thanks for catching that. Really must switch to a better terminal font. Alternatively, really must do a full buildworld to test changes when committing changes to make? As someone else who broke the build briefly in the last day or two, I make no claims as to being perfect, but things like make are really pretty sensitive. The other class of changes I have in mind for more thorough review at testing are rtld changes, which we've seen a lot of recently, not all thoroughly reviewed. Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Network Associates Laboratories To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message