From owner-freebsd-ports@FreeBSD.ORG Mon Jun 7 17:59:55 2004 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CAF0816A4CE; Mon, 7 Jun 2004 17:59:55 +0000 (GMT) Received: from lakermmtao04.cox.net (lakermmtao04.cox.net [68.230.240.35]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2695E43D4C; Mon, 7 Jun 2004 17:59:55 +0000 (GMT) (envelope-from conrads@cox.net) Received: from ip68-11-70-23.no.no.cox.net ([68.11.70.23]) by lakermmtao04.cox.netESMTP <20040607175952.DPTT12116.lakermmtao04.cox.net@ip68-11-70-23.no.no.cox.net>; Mon, 7 Jun 2004 13:59:52 -0400 Received: from ip68-11-70-23.no.no.cox.net (localhost.no.no.cox.net [127.0.0.1])i57HxseV090429; Mon, 7 Jun 2004 12:59:54 -0500 (CDT) (envelope-from conrads@ip68-11-70-23.no.no.cox.net) Received: (from conrads@localhost)i57HxmFS090428; Mon, 7 Jun 2004 12:59:48 -0500 (CDT) (envelope-from conrads) Message-ID: X-Mailer: XFMail 1.5.5 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20040606014518.4DB8154F5@mail.halplant.com> Date: Mon, 07 Jun 2004 12:59:48 -0500 (CDT) From: Conrad Sabatier To: "Andrew J.Caines" cc: ports@freebsd.org cc: deischen@freebsd.org cc: FreeBSD-gnats-submit@freebsd.org Subject: Re: Non-Maintainer update: editors/nedit - Add BUILD_BROKEN_NEDIT to build with Open Motif 2.2.2 (default) X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: conrads@cox.net List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 17:59:55 -0000 On 06-Jun-2004 Andrew J.Caines wrote: > >>Description: > Port build fails with default Motif (open-motif-2.2.2_2) because NEdit > authors don't want to build against Open Motif 2.2.2: [snip] > Note that I've modified patch-ac which already changes the nedit FreeBSD > Makefile. > > There has been some discussion about the validity of the NEdit authors' > position on stability, however I suggest this patch independently of this > argument for the simple reason that the port fails to install by default. See > the freebsd-ports archive for details. I just e-mailed the port maintainer the other day with exactly the same suggestion, but was met with some resistance. He stated that the port *does* build, if you use CFLAGS+= instead of CFLAGS= in /etc/make.conf. This is true enough, yet the standard make.conf under /usr/share/examples/etc uses CFLAGS=, not CFLAGS+=, so I really think people are more likely to have CFLAGS= in their own /etc/make.conf, which, of course, breaks the build of nedit. I suggested that, just to be on the safe side, he go ahead and add -DBUILD_BROKEN_NEDIT in the suggested location, i.e., by patching ${WORKDIR}/makefiles/Makefile.freebsd, *not* in the port's Makefile, which is insufficient in most cases. This really should be done, I think. -- Conrad Sabatier - "In Unix veritas"