From owner-cvs-src-old@FreeBSD.ORG Wed Dec 2 02:47:53 2009 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DCB5A1065740 for ; Wed, 2 Dec 2009 02:47:53 +0000 (UTC) (envelope-from wollman@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id C83D48FC1B for ; Wed, 2 Dec 2009 02:47:53 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id nB22lrhE055647 for ; Wed, 2 Dec 2009 02:47:53 GMT (envelope-from wollman@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id nB22lr9S055646 for cvs-src-old@freebsd.org; Wed, 2 Dec 2009 02:47:53 GMT (envelope-from wollman@repoman.freebsd.org) Message-Id: <200912020247.nB22lr9S055646@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to wollman@repoman.freebsd.org using -f From: Garrett Wollman Date: Wed, 2 Dec 2009 02:47:29 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: RELENG_8 Subject: cvs commit: src/lib/libc/gen getcap.c getusershell.c wordexp.c src/lib/libc/rpc clnt_raw.c getnetconfig.c key_call.c svc_raw.c src/lib/libc/stdio fgetws.c fvwrite.c vfwprintf.c src/lib/libc/yp yplib.c X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Dec 2009 02:47:53 -0000 wollman 2009-12-02 02:47:29 UTC FreeBSD src repository Modified files: (Branch: RELENG_8) lib/libc/gen getcap.c getusershell.c wordexp.c lib/libc/rpc clnt_raw.c getnetconfig.c key_call.c svc_raw.c lib/libc/stdio fgetws.c fvwrite.c vfwprintf.c lib/libc/yp yplib.c Log: SVN rev 200016 on 2009-12-02 02:47:29Z by wollman MFC revs 199781,199782,199784,199785,199786: Eliminate dead stores. In __mbsconv(), if prec was zero, nconv could have been used uninitialized. Initialize it to a safe value so that there's no chance of returning an error if stack garbage happens to be equal to (size_t)-1 or (size_t)-2. In svc_raw_reply(), don't leave stat uninitialized if the MSG_ACCEPTED && SUCCESS case succeeds. The stack garbage might be zero. In clnt_raw_create(), avoid minor race condition initializing the file-scope variable clntraw_private. Found by: Clang static analyzer Revision Changes Path 1.22.2.2 +2 -3 src/lib/libc/gen/getcap.c 1.10.10.2 +1 -1 src/lib/libc/gen/getusershell.c 1.6.30.2 +1 -1 src/lib/libc/gen/wordexp.c 1.20.10.2 +7 -4 src/lib/libc/rpc/clnt_raw.c 1.16.2.2 +2 -2 src/lib/libc/rpc/getnetconfig.c 1.16.10.2 +1 -1 src/lib/libc/rpc/key_call.c 1.16.2.2 +2 -3 src/lib/libc/rpc/svc_raw.c 1.7.2.2 +1 -1 src/lib/libc/stdio/fgetws.c 1.18.10.2 +1 -1 src/lib/libc/stdio/fvwrite.c 1.41.2.2 +1 -1 src/lib/libc/stdio/vfwprintf.c 1.51.10.2 +1 -1 src/lib/libc/yp/yplib.c