From owner-svn-src-releng@freebsd.org Wed Jul 24 12:54:11 2019 Return-Path: Delivered-To: svn-src-releng@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 23C43A76E9; Wed, 24 Jul 2019 12:54:11 +0000 (UTC) (envelope-from gordon@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 05A7A8119B; Wed, 24 Jul 2019 12:54:11 +0000 (UTC) (envelope-from gordon@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id D2405E9E5; Wed, 24 Jul 2019 12:54:10 +0000 (UTC) (envelope-from gordon@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id x6OCsAou076298; Wed, 24 Jul 2019 12:54:10 GMT (envelope-from gordon@FreeBSD.org) Received: (from gordon@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id x6OCsABl076296; Wed, 24 Jul 2019 12:54:10 GMT (envelope-from gordon@FreeBSD.org) Message-Id: <201907241254.x6OCsABl076296@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: gordon set sender to gordon@FreeBSD.org using -f From: Gordon Tetlow Date: Wed, 24 Jul 2019 12:54:10 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-releng@freebsd.org Subject: svn commit: r350283 - in releng: 11.2/sys/compat/freebsd32 11.3/sys/compat/freebsd32 X-SVN-Group: releng X-SVN-Commit-Author: gordon X-SVN-Commit-Paths: in releng: 11.2/sys/compat/freebsd32 11.3/sys/compat/freebsd32 X-SVN-Commit-Revision: 350283 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 05A7A8119B X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.93 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.93)[-0.926,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US] X-BeenThere: svn-src-releng@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the release engineering / security commits to the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Jul 2019 12:54:11 -0000 Author: gordon Date: Wed Jul 24 12:54:10 2019 New Revision: 350283 URL: https://svnweb.freebsd.org/changeset/base/350283 Log: Fix kernel memory disclosure in freebsd32_ioctl. Approved by: so Security: FreeBSD-SA-19:14.freebsd32 Security: CVE-2019-5605 Modified: releng/11.2/sys/compat/freebsd32/freebsd32_ioctl.c releng/11.3/sys/compat/freebsd32/freebsd32_ioctl.c Modified: releng/11.2/sys/compat/freebsd32/freebsd32_ioctl.c ============================================================================== --- releng/11.2/sys/compat/freebsd32/freebsd32_ioctl.c Wed Jul 24 12:53:06 2019 (r350282) +++ releng/11.2/sys/compat/freebsd32/freebsd32_ioctl.c Wed Jul 24 12:54:10 2019 (r350283) @@ -262,6 +262,8 @@ freebsd32_ioctl_pciocgetconf(struct thread *td, vm_offset_t addr; int error; + memset(&pmc, 0, sizeof(pmc)); + memset(&pc32, 0, sizeof(pc32)); if ((error = copyin(uap->data, &pci32, sizeof(pci32))) != 0) return (error); Modified: releng/11.3/sys/compat/freebsd32/freebsd32_ioctl.c ============================================================================== --- releng/11.3/sys/compat/freebsd32/freebsd32_ioctl.c Wed Jul 24 12:53:06 2019 (r350282) +++ releng/11.3/sys/compat/freebsd32/freebsd32_ioctl.c Wed Jul 24 12:54:10 2019 (r350283) @@ -262,6 +262,8 @@ freebsd32_ioctl_pciocgetconf(struct thread *td, vm_offset_t addr; int error; + memset(&pmc, 0, sizeof(pmc)); + memset(&pc32, 0, sizeof(pc32)); if ((error = copyin(uap->data, &pci32, sizeof(pci32))) != 0) return (error);