From owner-dev-commits-ports-all@freebsd.org Wed May 12 00:34:44 2021 Return-Path: Delivered-To: dev-commits-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3BD6062BE2A; Wed, 12 May 2021 00:34:44 +0000 (UTC) (envelope-from fullermd@over-yonder.net) Received: from mail.infocus-llc.com (mail.infocus-llc.com [199.15.120.13]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Ffwm30jQnz3H3J; Wed, 12 May 2021 00:34:42 +0000 (UTC) (envelope-from fullermd@over-yonder.net) Received: from draco.over-yonder.net (c-174-50-4-214.hsd1.ms.comcast.net [174.50.4.214]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.tarragon.infocus-llc.com (Postfix) with ESMTPSA id 4Ffwlw3166zMqL; Tue, 11 May 2021 19:34:36 -0500 (CDT) Received: by draco.over-yonder.net (Postfix, from userid 100) id 4Ffwlt66rjz7HK; Tue, 11 May 2021 19:34:34 -0500 (CDT) Date: Tue, 11 May 2021 19:34:34 -0500 From: "Matthew D. Fuller" To: Adriaan de Groot Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 1c31059e3d12 - main - x11-wm/twm: generate synthetic WM hints when needed Message-ID: References: <202105042311.144NB1gG091594@gitrepo.freebsd.org> <5586518.Zv9zXsTiuT@beastie.bionicmutton.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5586518.Zv9zXsTiuT@beastie.bionicmutton.org> X-Editor: vi X-OS: FreeBSD User-Agent: Mutt/2.0.6 (2021-03-06) X-Rspamd-Queue-Id: 4Ffwm30jQnz3H3J X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of fullermd@over-yonder.net designates 199.15.120.13 as permitted sender) smtp.mailfrom=fullermd@over-yonder.net X-Spamd-Result: default: False [-2.57 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; R_SPF_ALLOW(-0.20)[+mx]; DMARC_NA(0.00)[over-yonder.net]; SPAMHAUS_ZRD(0.00)[199.15.120.13:from:127.0.2.255]; RECEIVED_SPAMHAUS_PBL(0.00)[174.50.4.214:received]; NEURAL_HAM_MEDIUM(-0.31)[-0.315]; RBL_DBL_DONT_QUERY_IPS(0.00)[199.15.120.13:from]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.95)[-0.953]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:33069, ipnet:199.15.120.0/22, country:US]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[dev-commits-ports-all,dev-commits-ports-main]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: dev-commits-ports-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the ports repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 May 2021 00:34:44 -0000 On Mon, May 10, 2021 at 12:44:45AM +0200 I heard the voice of Adriaan de Groot, and lo! it spake thus: > > I'm a bit confused by the "XXX Revisit?" comment and then lines > 349-351, which set wmhints->input=True .. something that that > "revisit" line has already done unconditionally. Well, that's part of why it got an XXX and plea as part of the changes :) It was meant as a minimal change to just synthesize the WM_HINTS data; de-NULL-checking was part of that, but changing the logic (using the word loosely ;) around it was saved for later. Later work redid a lot of that (e.g., r569, r626, etc). The current code has a lot of that resolved[0]. Of course, that's well beyond "fix immediate problem with Chrome", and way more C than you wanna see :) [0] https://bazaar.launchpad.net/~ctwm/ctwm/trunk/view/682/add_window.c#L314 https://bazaar.launchpad.net/~ctwm/ctwm/trunk/view/682/win_utils.c#L1039 and so on. -- Matthew Fuller (MF4839) | fullermd@over-yonder.net Systems/Network Administrator | http://www.over-yonder.net/~fullermd/ On the Internet, nobody can hear you scream.