From owner-cvs-all@FreeBSD.ORG Sun Jul 3 01:10:11 2005 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DC91716A95B; Sun, 3 Jul 2005 00:58:34 +0000 (GMT) (envelope-from ps@mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id E2AAD4468A; Sun, 3 Jul 2005 00:42:47 +0000 (GMT) (envelope-from ps@mu.org) Received: by elvis.mu.org (Postfix, from userid 1000) id 8900C6DCCB; Sat, 2 Jul 2005 17:38:10 -0700 (PDT) X-Original-To: ps@mu.org Delivered-To: ps@mu.org Received: from mx2.freebsd.org (mx2.freebsd.org [216.136.204.119]) by elvis.mu.org (Postfix) with ESMTP id 7E1C75C9C5 for ; Tue, 25 Jan 2005 05:06:19 -0800 (PST) Received: from hub.freebsd.org (hub.freebsd.org [216.136.204.18]) by mx2.freebsd.org (Postfix) with ESMTP id 4A777566DE for ; Tue, 25 Jan 2005 13:06:01 +0000 (GMT) (envelope-from owner-src-committers@FreeBSD.org) Received: by hub.freebsd.org (Postfix) id 958F316A4E0; Tue, 25 Jan 2005 13:05:55 +0000 (GMT) Delivered-To: ps@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 538) id 19AB616A4D0; Tue, 25 Jan 2005 13:05:53 +0000 (GMT) Delivered-To: src-committers@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 680) id F245D16A4CF; Tue, 25 Jan 2005 13:05:51 +0000 (GMT) From: Darren Reed To: Giorgos Keramidas Message-ID: <20050125130551.GA91763@hub.freebsd.org> References: <200501080432.j084W2BG093532@repoman.freebsd.org> <20050109231923.GG832@gothmog.gr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050109231923.GG832@gothmog.gr> User-Agent: Mutt/1.4.2.1i Sender: owner-src-committers@FreeBSD.org Precedence: bulk X-Loop: FreeBSD.ORG X-Spam-Checker-Version: SpamAssassin 3.0.1 (2004-10-22) on elvis.mu.org X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.0.1 X-Spam-Level: Cc: Darren Reed , "Bjoern A. Zeeb" , src-committers@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/sys/contrib/ipfilter/netinet fil.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Sun, 03 Jul 2005 01:10:11 -0000 X-Original-Date: Tue, 25 Jan 2005 13:05:51 +0000 X-List-Received-Date: Sun, 03 Jul 2005 01:10:11 -0000 On Mon, Jan 10, 2005 at 01:19:23AM +0200, Giorgos Keramidas wrote: > On 2005-01-08 21:14, "Bjoern A. Zeeb" wrote: > > On Sat, 8 Jan 2005, Darren Reed wrote: > > > darrenr 2005-01-08 04:32:02 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/contrib/ipfilter/netinet fil.c > > > Log: > > > Elminate 1 LOR (actually a recursive mutex grab) involving ipfilter where > > > we loop through all the list of NICs (struct ifnet), holding the lock on > > > it and then do a name lookup with ifunit() whilst holding it. > > > > > > Revision Changes Path > > > 1.43 +2 -25 src/sys/contrib/ipfilter/netinet/fil.c > > > > could you please tellme which one of the the three 50-52 of > > http://sources.zabbadoz.net/freebsd/lor.html > > got fixed with this commit so I can update the state? > > I don't think it's listed there, as it's not a LOR per se. No recursive > mutex acquisitions are listed in the URL above. I believe the patch fixes this - http://sources.zabbadoz.net/freebsd/lor.html#050 - which is a recursive mutex problem, too. Darren