From owner-svn-src-projects@FreeBSD.ORG Thu Aug 25 11:49:34 2011 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A85AF106566C; Thu, 25 Aug 2011 11:49:34 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 7EAE78FC08; Thu, 25 Aug 2011 11:49:34 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 1CCE846B1A; Thu, 25 Aug 2011 07:49:34 -0400 (EDT) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id B03B68A02F; Thu, 25 Aug 2011 07:49:33 -0400 (EDT) From: John Baldwin To: mdf@freebsd.org Date: Thu, 25 Aug 2011 07:49:32 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110617; KDE/4.5.5; amd64; ; ) References: <201108242214.p7OMEuMP072758@svn.freebsd.org> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201108250749.32660.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Thu, 25 Aug 2011 07:49:33 -0400 (EDT) Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r225154 - in projects/ino64/sys/ufs: ffs ufs X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Aug 2011 11:49:34 -0000 On Wednesday, August 24, 2011 7:09:24 pm mdf@freebsd.org wrote: > On Wed, Aug 24, 2011 at 3:14 PM, Matthew D Fleming wrote: > > Author: mdf > > Date: Wed Aug 24 22:14:55 2011 > > New Revision: 225154 > > URL: http://svn.freebsd.org/changeset/base/225154 > > > > Log: > > Use fixed-width types in on-disk structures. This takes care of all the > > ino_t references I could find that were on-disk. > > > > GSoC r223157. > > Code by Gleb Kurtsou. > > Note that I've explicitly left all the XXXfid structs alone; when > ino_t is changed to 64-bit they will use 64-bit members for inode > number. The only in-tree one that may be a problem is ReiserFS which > will have a 32 byte FID after compiler padding is applied. This can > be reduced to 24 bytes by reordering the members. In theory, IIRC, > even 32 bits is an okay FID, however I have seen a note at $WORK that > NFSv2 has 32 byte file handles and BSD is using 8 bytes for the fsid. > > If anyone knows anything more, please let me know. For the moment I > think my plan is to re-order the members of various implementations to > keep them smaller, and leave it as an ino_t in the struct definition. One suggestion I do have in regards to this branch. Earlier there was a request to increase the userland dev_t to 32-bits. The primary user of this would seem to be OpenAFS. Gleb did not agree to do this, but I actually think we should go ahead and bump dev_t. Changing for the layout of stat is a lot of work and I'd rather err on the side of being too future proof than deciding 2 years from now "gee, we really could have used a bigger dev_t". -- John Baldwin