From owner-cvs-all Thu Oct 24 13:42:55 2002 Delivered-To: cvs-all@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 931) id 1DC5E37B401; Thu, 24 Oct 2002 13:42:54 -0700 (PDT) Date: Thu, 24 Oct 2002 13:42:54 -0700 From: Juli Mallett To: John Baldwin Cc: Mark Valentine , cvs-all@freebsd.org, cvs-committers@freebsd.org, "\"Sam Leffler\"" Subject: Re: cvs commit: src/usr.bin/make var.c Message-ID: <20021024134254.B85410@FreeBSD.org> References: <200210242031.g9OKVWrt047633@dotar.thuvia.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: ; from jhb@FreeBSD.org on Thu, Oct 24, 2002 at 04:36:53PM -0400 Organisation: The FreeBSD Project X-Alternate-Addresses: , , , , X-Towel: Yes X-LiveJournal: flata, jmallett X-Negacore: Yes Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG * De: John Baldwin [ Data: 2002-10-24 ] [ Subjecte: Re: cvs commit: src/usr.bin/make var.c ] > > On 24-Oct-2002 Mark Valentine wrote: > >> From: sam@errno.com ("Sam Leffler") > >> Date: Thu 24 Oct, 2002 > >> Subject: Re: cvs commit: src/usr.bin/make var.c > > > >> Juli, this breaks make in groff/tmac (looks like the $f var sub is not done > >> right). Please back it out for now. > > > > Looks like Juli transposed var[1] into val[1]... (Just checked the OpenBSD > > code.) > > Fixing it would be suitable then. :) Changes to 'make' really should be tested > with a 'make buildworld' though. Sorry, I was going through lots of different make(1) code last night, and remembered running into this and fixing it from OpenBSD a long long time ago (I had something which broke on FreeBSD), and I know I used that make(1) for a long time. And what with it being a one-line fix, I figured I couldn't screw it up - I amaze myself sometimes ;) Anyway, I did a small run over the stuff that most frequently breaks locally with make(1) changes and didn't hit anything with it, but I should have done a full buildworld to be sure. juli. -- Juli Mallett | FreeBSD: The Power To Serve Will break world for fulltime employment. | finger jmallett@FreeBSD.org http://people.FreeBSD.org/~jmallett/ | Support my FreeBSD hacking! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message