From owner-svn-ports-all@freebsd.org Thu Feb 25 11:50:08 2021 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 19957560098; Thu, 25 Feb 2021 11:50:08 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DmWLS0G22z4ZWP; Thu, 25 Feb 2021 11:50:08 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from mail.j.mat.cc (owncloud.cube.mat.cc [79.143.240.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.mat.cc", Issuer "R3" (verified OK)) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id D458124AF7; Thu, 25 Feb 2021 11:50:07 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from aching.in.mat.cc (unknown [IPv6:2a01:678:42:0:2edf:987c:c428:4585]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: mat@mat.cc) by mail.j.mat.cc (Postfix) with ESMTPSA id A39BE942D80; Thu, 25 Feb 2021 11:50:06 +0000 (UTC) Date: Thu, 25 Feb 2021 12:50:05 +0100 From: Mathieu Arnold To: Jan Beich Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r566529 - head/x11/foot Message-ID: <20210225115005.ebfocnpwupvnjubk@aching.in.mat.cc> References: <202102251130.11PBUM4M013317@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6xngppuugy4zdy47" Content-Disposition: inline In-Reply-To: <202102251130.11PBUM4M013317@repo.freebsd.org> X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Feb 2021 11:50:08 -0000 --6xngppuugy4zdy47 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 25, 2021 at 11:30:22AM +0000, Jan Beich wrote: > +post-patch: terminfo-patch > +terminfo-patch: > + @${REINPLACE_CMD} '/datadir/s/terminfo/site-&/' ${WRKSRC}/meson.build This seems overengineered, there is no post-patch target in the Makefile, so, why create a new target, and hook it up to a non existing target, instead of just using a regular post-patch target? If there is a good reason for that, it is not obvious, and the reason needs to be documented in the Makefile. --=20 Mathieu Arnold --6xngppuugy4zdy47 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEVhwchfRfuV0unqO5KesJApEdfgIFAmA3juhfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU2 MUMxQzg1RjQ1RkI5NUQyRTlFQTNCOTI5RUIwOTAyOTExRDdFMDIACgkQKesJApEd fgLp3A//cEXykoII3btGqNvwSenP220uzFjDyg+VEh5aWGsC69pG2Lxxer3dBemV NmdHBDX8GK6nph9c8aDRtNvjbs6shwFcn/VOGlKHG5HUfw7WydP3h+abm1LviEIM 1Ls62zUmW71T2zFQFzlG03UviQsoIKEriU3yhdRv90PNAMCYv66/yzauiliklbzi Oz2V4/vFN6O1RYxZ0qctGrq9jxAmoPSamddCIOQFjROlPAvpvucEbBe3XnaL32T3 34P/pIFeoa1hwaqU8VCgELkP7UZ5n552J1bsbr/F5GDIg7rP65lxJ1WusaOCQHZO VwKvpM77mvmpubNgzBN3lshHxvU2mxh+AL7RWIWOKikhyrtGz7CWiLdsiJ3FIVYD uQTQo+obghj7qLK3scnpYjg09xD77mE9C9IT7gPx+RXVh2eXdY+i+ugf9QN7Ikfz QA8bViHY4ks5Rs+zX3xHVrAO7miq3fQAubVXVhm15UPZBHplJEblOgpqfV1HiW9M vNKU+cVd860QeNjIhx23sdGm3cJqIvrGGmW7eg01nELjSfsnUbQwSoY2ewgX5rId AlqWztX6mgUvnA4VVxEl9Q84SiHAAxB73nTudHwPcXrzLmwpvhHU8hsZGv5DFdjB YVevbVZ5PsgNrWupTT8JBpUZc4nOmv4qHHwzZQGnFHXLkD2MWqQ= =9zsd -----END PGP SIGNATURE----- --6xngppuugy4zdy47--