From owner-cvs-src@FreeBSD.ORG Tue Apr 15 02:03:52 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9085137B401; Tue, 15 Apr 2003 02:03:52 -0700 (PDT) Received: from wantadilla.lemis.com (wantadilla.lemis.com [192.109.197.80]) by mx1.FreeBSD.org (Postfix) with ESMTP id 09AAE43FE1; Tue, 15 Apr 2003 02:03:50 -0700 (PDT) (envelope-from grog@lemis.com) Received: by wantadilla.lemis.com (Postfix, from userid 1004) id 1FD2451A68; Tue, 15 Apr 2003 18:33:48 +0930 (CST) Date: Tue, 15 Apr 2003 18:33:48 +0930 From: Greg 'groggy' Lehey To: Tim Robbins Message-ID: <20030415090348.GJ10776@wantadilla.lemis.com> References: <200304121039.h3CAduH7079324@repoman.freebsd.org> <20030415050607.GF8718@wantadilla.lemis.com> <20030415184815.A11784@dilbert.robbins.dropbear.id.au> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Tu8ztk+XgTAiG9Id" Content-Disposition: inline In-Reply-To: <20030415184815.A11784@dilbert.robbins.dropbear.id.au> User-Agent: Mutt/1.4i Organization: The FreeBSD Project Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 WWW-Home-Page: http://www.FreeBSD.org/ X-PGP-Fingerprint: 9A1B 8202 BCCE B846 F92F 09AC 22E6 F290 507A 4223 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/ps keyword.c print.c ps.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Apr 2003 09:03:53 -0000 --Tu8ztk+XgTAiG9Id Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tuesday, 15 April 2003 at 18:48:15 +1000, Tim Robbins wrote: > On Tue, Apr 15, 2003 at 02:36:07PM +0930, Greg 'groggy' Lehey wrote: > >> On Saturday, 12 April 2003 at 3:39:56 -0700, Tim J. Robbins wrote: >>> tjr 2003/04/12 03:39:56 PDT >>> >>> FreeBSD src repository >>> >>> Modified files: >>> bin/ps keyword.c print.c ps.h >>> Log: >>> Display residency and sleep times (re and sl fields) larger than 127 as 127. >>> This is what the manual page says ps should do, and what OpenBSD and NetBSD do. >> >> Why is this a Good Thing? > > Two reasons: it makes the output of "ps -v" less ugly, and it makes the code > consistent with the documentation. "This is the way we've documented it, so this is the way it has to be" :-) > It's a waste of information though. What do you suggest instead? > Dynamically resizing the column width to fit the number would be one > alternative. Yes, I checked the options before I replied. If it's just a matter of column width, I'd suggest going to 999 and replacing larger values with the text ">1K", which is the same width. But maybe dynamic resizing would make more sense. I wonder why the other BSDs do it this way. I can't imagine that it was a very conscious decision. Could it be that at some point the value was never larger (signed char)? Greg -- See complete headers for address and phone numbers --Tu8ztk+XgTAiG9Id Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.0 (FreeBSD) iD8DBQE+m8r0IubykFB6QiMRAjFBAJ9iioN1buCtt/rxsvjJDh4A7K4sqwCeN4xl ExUNjf5wYLK7CMSqNbLd6rU= =bVZu -----END PGP SIGNATURE----- --Tu8ztk+XgTAiG9Id--