Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 1 Nov 2002 19:14:11 +0100
From:      Marco Molteni <molter@tin.it>
To:        FreeBSD-gnats-submit@FreeBSD.org
Subject:   ports/44811: [UPDATE] net/tightvnc
Message-ID:  <20021101181411.38467.qmail@cobweb.example.org>

next in thread | raw e-mail | index | archive | help

>Number:         44811
>Category:       ports
>Synopsis:       [UPDATE] net/tightvnc
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Fri Nov 01 10:20:00 PST 2002
>Closed-Date:
>Last-Modified:
>Originator:     Marco Molteni
>Release:        FreeBSD 4.7-RC i386
>Organization:
Citello Networks
>Environment:
>Description:

    The Xvnc server of port net/tightvnc fails to bind to an address when
    invoked with the -localhost or -interface options.
    
    This means that one cannot force the connections to the server to be
    only thru SSH port forwarding, degrading system security.
    
    Following easy patch fixes the problem. I also sent the patch to
    the tightvnc developers.

>How-To-Repeat:

    [note that vncserver is a wrapper for Xvnc]

    $ vncserver -localhost
    or
    $ vncserver -interface <ipaddress>

>Fix:

    Put following patch in
    net/tightvnc/files/patch-Xvnc::programs::Xserver::hw::vnc::sockets.c

    You may also want to bump the revision number in the port Makefile.


--- Xvnc/programs/Xserver/hw/vnc/sockets.c      Tue Mar 19 18:59:22 2002
+++ Xvnc/programs/Xserver/hw/vnc/sockets.c      Fri Nov  1 18:03:02 2002
@@ -38,6 +38,7 @@
  */
 
 #include <stdio.h>
+#include <string.h>
 #include <sys/types.h>
 #include <sys/time.h>
 #include <sys/socket.h>
@@ -491,6 +492,7 @@
     int sock;
     int one = 1;
 
+    memset(&addr, 0, sizeof(addr));
     addr.sin_family = AF_INET;
     addr.sin_port = htons(port);
     addr.sin_addr.s_addr = interface.s_addr;


>Release-Note:
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021101181411.38467.qmail>