From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Aug 20 04:10:03 2009 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EC0F5106568D for ; Thu, 20 Aug 2009 04:10:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id CBA508FC65 for ; Thu, 20 Aug 2009 04:10:03 +0000 (UTC) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n7K4A3aQ073442 for ; Thu, 20 Aug 2009 04:10:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n7K4A3J3073441; Thu, 20 Aug 2009 04:10:03 GMT (envelope-from gnats) Resent-Date: Thu, 20 Aug 2009 04:10:03 GMT Resent-Message-Id: <200908200410.n7K4A3J3073441@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Jonathan Chen Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 52F1A1065690 for ; Thu, 20 Aug 2009 04:01:19 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 4488E8FC62 for ; Thu, 20 Aug 2009 04:01:19 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n7K41JTu038850 for ; Thu, 20 Aug 2009 04:01:19 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id n7K41IlD038849; Thu, 20 Aug 2009 04:01:18 GMT (envelope-from nobody) Message-Id: <200908200401.n7K41IlD038849@www.freebsd.org> Date: Thu, 20 Aug 2009 04:01:18 GMT From: Jonathan Chen To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/137985: security/openssh-portable: [PATCH] sftp crashes on directory listing X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Aug 2009 04:10:04 -0000 >Number: 137985 >Category: ports >Synopsis: security/openssh-portable: [PATCH] sftp crashes on directory listing >Confidential: no >Severity: serious >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Aug 20 04:10:03 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Jonathan Chen >Release: 8.0-BETA2 amd64 >Organization: >Environment: FreeBSD builder 8.0-BETA2 FreeBSD 8.0-BETA2 #0: Fri Aug 14 19:03:00 EDT 2009 jon@builder:/usr/obj/usr/src/sys/DFLT amd64 >Description: On FreeBSD, openbsd-compat's glob is supposed to be used used instead of the system glob, due to BROKEN_GLOB being set in configure. However, includes.h pulls in the system glob.h nonetheless, resulting in divergent glob_t definitions within openssh. This manifests as sftp throwing a SIGBUS when a directory listing is requested. NB: contrary to the claim in the Makefile, openssh-portable seems to compile just fine on OSVERSION==800104 (once you remove the BROKEN= line) >How-To-Repeat: cd /usr/ports/security/openssh-portable make work/openssh-5.2p1/sftp localhost [login] ls *SIGBUS* >Fix: drop the following patch into files/patch-blah --- includes.h~ 2009-08-19 23:32:26.000000000 -0400 +++ includes.h 2009-08-19 23:32:53.000000000 -0400 @@ -31,7 +31,8 @@ #endif #if defined(HAVE_GLOB_H) && defined(GLOB_HAS_ALTDIRFUNC) && \ defined(GLOB_HAS_GL_MATCHC) && \ - defined(HAVE_DECL_GLOB_NOMATCH) && HAVE_DECL_GLOB_NOMATCH != 0 + defined(HAVE_DECL_GLOB_NOMATCH) && HAVE_DECL_GLOB_NOMATCH != 0 &&\ + !defined(BROKEN_GLOB) # include #endif #ifdef HAVE_ENDIAN_H >Release-Note: >Audit-Trail: >Unformatted: