From owner-freebsd-multimedia@FreeBSD.ORG Tue Jun 13 10:23:52 2006 Return-Path: X-Original-To: freebsd-multimedia@freebsd.org Delivered-To: freebsd-multimedia@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1306116A41A for ; Tue, 13 Jun 2006 10:23:52 +0000 (UTC) (envelope-from nikolas.britton@gmail.com) Received: from nz-out-0102.google.com (nz-out-0102.google.com [64.233.162.195]) by mx1.FreeBSD.org (Postfix) with ESMTP id D492843D5A for ; Tue, 13 Jun 2006 10:23:50 +0000 (GMT) (envelope-from nikolas.britton@gmail.com) Received: by nz-out-0102.google.com with SMTP id m7so996491nzf for ; Tue, 13 Jun 2006 03:23:50 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=cviBKQAj3AXtktsfepTdqiIuUjet2MNujJmjTC+KRe013PG/vUEY04RU0XXKtbUD0sBV+WWXIx8NuAx8ibW3BtczTIiwdtvCXCwmurOOab36VM8VoS1EQlCByE4HnsJ5FUYijAS2aBuOmqrjMlZWYcGPUA0mjZTOhV88mIYO2Q8= Received: by 10.36.216.6 with SMTP id o6mr3656242nzg; Tue, 13 Jun 2006 03:23:50 -0700 (PDT) Received: by 10.36.101.10 with HTTP; Tue, 13 Jun 2006 03:23:50 -0700 (PDT) Message-ID: Date: Tue, 13 Jun 2006 05:23:50 -0500 From: "Nikolas Britton" To: "Konstantin Dimitrov" , "Stefan Ehmann" In-Reply-To: <8103ad500606130247w63cce8e7j9ab9cb4428228811@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200606072039.13422.shoesoft@gmx.net> <8103ad500606071552k77985b54o3378d9351e4bdcf8@mail.gmail.com> <200606081614.43375.shoesoft@gmx.net> <8103ad500606081031s40ac1afcnfc78bd6734e43fdc@mail.gmail.com> <8103ad500606121534h2a9480aem8be58220c2e04996@mail.gmail.com> <8103ad500606130247w63cce8e7j9ab9cb4428228811@mail.gmail.com> Cc: freebsd-multimedia@freebsd.org, Alexander@leidinger.net Subject: Re: Status of VIA Envy24 audio controller X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Jun 2006 10:23:52 -0000 On 6/13/06, Konstantin Dimitrov wrote: > i found obvious bug, that affects all cards: "codec->type = dvc;" (ak452x.c) > obviously should be "codec->dvc = dvc;", this cause the previously mentioned > volume problem with "M-Audio Audiophile 2496", so original "ak452x_set" > routine is ok, after fixing "codec->type = dvc;" to "codec->dvc = dvc;", we > have working "mixer vol ..." with both "Terratec DMX 6fire" and "M-Audio > Audiophile 2496", of cource correct codec type should be set in envy24.c : > "ak452x_settype(ptr->info, AK452X_TYPE_4528);" for "M-Audio Audiophile 2496" > "ak452x_settype(ptr->info, AK452X_TYPE_4524);" for "Terratec DMX 6fire" > > after fixing the bug described above, both cards working now only with > touching hardware specific parts of the Katsurajima Naoto's code - to be > more specific - 3 lines to set right wiring in envy24.h (codec CS, CDTI, > CCLK) and 1 line to set right codec in envy24.c, so Katsurajima Naoto's code > is pretty generic and so it can be used as a base for Envy24 driver > supporting many Envy24-based audio cards under FreeBSD. > > > On 6/13/06, Konstantin Dimitrov < kosio.dimitrov@gmail.com> wrote: > > > > thanks to cooperation with Stefan Ehmann (shoesoft at gmx.net), there is a > patch adding basic "M-Audio Audiophile 2496" support, he sent the initial > patch to freebsd-multimedia@ titled "basic support for M-Audio Audiophile > 2496 available", now the "volume" problem with "M-Audio Audiophile 2496" is > fixed using slightly changed "ak452x_set" ( ak452x.c) routine: > > > > void > > ak452x_set(struct ak452x_info *codec, int dir, unsigned int left, unsigned > int right) > > { > > > > #if(0) > > device_printf(codec->dev, "ak452x_set(codec, %d, %d, %d)\n", dir, > left, right); > > > > #endif > > snd_mtxlock(codec->lock); > > > > if (left >= 100) > > left = 127; > > else > > left = left * 127 / 100; > > if (right >= 100) > > right = 127; > > else > > right = right * 127 / 100; > > > > if (dir == PCMDIR_PLAY) { > > > > #if(0) > > device_printf(codec->dev, "ak452x_set(): AK4528(PLAY) %d/%d\n", > left, right); > > #endif > > > > ak452x_wrcd(codec, AK4528_LOATT, left); > > ak452x_wrcd(codec, AK4528_ROATT, right); > > } > > > > snd_mtxunlock(codec->lock); > > } > > Cool!, I just order a Audiophile 2496, it should be in my hands by then end of the week for testing. Is it possible to get a diff of all the new code?: Patch set of the changes you made to get Katsurajima old code running again on 6.1-STABLE. Plus a patch set of the changes you and Stefan made to get audiophile 2496 running? -- BSD Podcasts @: http://bsdtalk.blogspot.com/ http://freebsdforall.blogspot.com/