From owner-svn-src-head@freebsd.org Mon Mar 11 18:17:57 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 364971528A94; Mon, 11 Mar 2019 18:17:57 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C6CAB74496; Mon, 11 Mar 2019 18:17:56 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from freefall.freebsd.org (static-71-168-218-4.cmdnnj.fios.verizon.net [71.168.218.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jkim/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 8876C1699D; Mon, 11 Mar 2019 18:17:56 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Subject: Re: svn commit: r344982 - head/sys/x86/isa To: Ravi Pokala , Vladimir Kondratyev , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201903102019.x2AKJiJY029807@repo.freebsd.org> <00F61A40-C128-4F75-A45F-A6CECBB791C2@panasas.com> From: Jung-uk Kim Openpgp: preference=signencrypt Autocrypt: addr=jkim@FreeBSD.org; prefer-encrypt=mutual; keydata= mQENBFJBztUBCAChqNyGqmFuNo0U7MBzsD+q/G6Cv0l7LGVrOAsgh34M8wIWhD+tztDWMVfn AhxNDd0ceCj2bYOe67sTQxAScEcbt2FfvPOLp9MEXb9qohZj172Gwkk7dnhOhZZKhVGVZKM4 NcsuBDUzgf4f3Vdzj4wg6WlqplnTZo8lPE4hZWvZHoFIyunPTJWenybeV1xnxK7JkUdSvQR0 fA59RfTTECMwTrSEfYGUnxIDBraxJ7Ecs/0hGQ7sljIj8WBvlRDU5fU1xfF35aw56T8POQRq F4E6RVJW3YGuTpSwgtGZOTfygcLRhAiq3dFC3JNLaTVTpM8PjOinJyt9AU6RoITGOKwDABEB AAG0Hkp1bmctdWsgS2ltIDxqa2ltQEZyZWVCU0Qub3JnPokBPQQTAQoAJwUCUkHO1QIbAwUJ E0/POwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgAAKCRB8n5Ym/NvxRqyzB/wL7QtsIpeGfGIA ZPMtgXMucM3NWzomyQMln2j2efUkDKthzh9jBxgF53TjOr7imwIt0PT2k1bqctPrq5IRqnu9 mGroqaCLE3LG2/E3jEaao4k9PO6efwlioyivUo5NrqIQOQ4k3EAXw7d2y0Dk1VpTgdMrnUAB hj7lGlLqS4ydcrf24DdbCRGdEQwqd9DBeBgbWynxAJMgbZBhYVEyIHuQKkJ8qY0ibIPXXuF0 KYDeH0qUHtWV2K3srNyPtymUkBQD84Pl1GWRYx05XdUHDmnX0JV3lg0BfYJZgZv0ehPQrMfY Fd9abTkf9FHQYz1JtsC8wUuRgqElRd6+YAGf8Tt9uQENBFJBztUBCADLtSrP44El2VoJmH14 OFrlOgxzZnbn+Y/Gf1k12mJBiR+A+pBeRLD50p7AiTrjHRxO3cHcl9Dh0uf1VSbXgp8Or0ye iP/86fZPd4k5HXNmDTLL0HecPE08SCqGZ0W8vllQrokB1QxxRUB+fFMPJyMCjDAZ7P9fFTOS dTw1bJSTtOD8Sx8MpZUa9ti06bXFlVYDlaqSdgk181SSx+ZbSKkQR8CIMARlHwiLsa3Z9q9O EJr20HPyxe0AlTvwvFndH61hg7ds63eRvglwRnNON28VXO/lvKXq7Br/CiiyhFdKfINIx2Z5 htYq22tgGTW7mBURbIKoECFBTX9Lv6BXz6w9ABEBAAGJASUEGAEKAA8FAlJBztUCGwwFCRNP zzsACgkQfJ+WJvzb8UZcJQf+IsTCxUEqY7W/pT84sMg5/QD3s6ufTRncvq14fEOxCNq1Rf4Q 9P+tOFa8GZfKDGB2BFGIrW7uT5mlmKdK1vO6ZIA930y5kUsnCmBUEBJkE2ciSQk01aB/1o62 Q3Gk/F6BwtNY9OXiqF7AcAo+K/BMIaqb26QKeh+IIgK1NN9dQiq3ByTbl4zpGZa6MmsnnRTu mzGKt2nkz7vBzH6+hZp1OzGZikgjjhYWVFoJo1dvf/rv4obs0ZJEqFPQs/1Qa1dbkKBv6odB XJpPH0ssOluTY24d1XxTiKTwmWvHeQkOKRAIfD7VTtF4TesoZYkf7hsh3e3VwXhptSLFnEOi WwYofg== Message-ID: Date: Mon, 11 Mar 2019 14:17:48 -0400 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.5.2 MIME-Version: 1.0 In-Reply-To: <00F61A40-C128-4F75-A45F-A6CECBB791C2@panasas.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8hW1Bii9Yy2oRgPkvBN6DR9CYkMVJ9WVe" X-Rspamd-Queue-Id: C6CAB74496 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.95 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.95)[-0.953,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Mar 2019 18:17:57 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --8hW1Bii9Yy2oRgPkvBN6DR9CYkMVJ9WVe Content-Type: multipart/mixed; boundary="ZzUiJPbxQg2h1sVl3OTdwnTXTx7lB2G6m"; protected-headers="v1" From: Jung-uk Kim To: Ravi Pokala , Vladimir Kondratyev , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: Subject: Re: svn commit: r344982 - head/sys/x86/isa References: <201903102019.x2AKJiJY029807@repo.freebsd.org> <00F61A40-C128-4F75-A45F-A6CECBB791C2@panasas.com> In-Reply-To: <00F61A40-C128-4F75-A45F-A6CECBB791C2@panasas.com> --ZzUiJPbxQg2h1sVl3OTdwnTXTx7lB2G6m Content-Type: multipart/mixed; boundary="------------24835374B76989557A313568" Content-Language: en-US This is a multi-part message in MIME format. --------------24835374B76989557A313568 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 19. 3. 11., Ravi Pokala wrote: > -----Original Message----- > From: on behalf of Vladimir Kondraty= ev > Date: 2019-03-10, Sunday at 13:19 > To: , , > Subject: svn commit: r344982 - head/sys/x86/isa >=20 >> Author: wulf >> Date: Sun Mar 10 20:19:43 2019 >> New Revision: 344982 >> URL: https://svnweb.freebsd.org/changeset/base/344982 >> >> Log: >> atrtc(4): install ACPI RTC/CMOS operation region handler >=20 > Hi Vladimir, >=20 > This appears to have broken all the various LINT kernels for amd64 and = i386: >=20 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > /usr/home/rpokala/freebsd/clean/base/head/sys/x86/isa/atrtc.c:321:2: er= ror: use of undeclared identifier '_AcpiModuleName' > ACPI_FUNCTION_TRACE((char *)(uintptr_t)__func__); > ^ > /usr/home/rpokala/freebsd/clean/base/head/sys/contrib/dev/acpica/includ= e/acoutput.h:480:18: note: expanded from macro 'ACPI_FUNCTION_TRACE' > AcpiUtTrace (ACPI_DEBUG_PARAMETERS) > ^ > /usr/home/rpokala/freebsd/clean/base/head/sys/contrib/dev/acpica/includ= e/acoutput.h:402:39: note: expanded from macro 'ACPI_DEBUG_PARAMETERS' > __LINE__, ACPI_GET_FUNCTION_NAME, _AcpiModuleName, _COMPONENT > ^ > /usr/home/rpokala/freebsd/clean/base/head/sys/x86/isa/atrtc.c:321:2: er= ror: use of undeclared identifier '_COMPONENT' > /usr/home/rpokala/freebsd/clean/base/head/sys/contrib/dev/acpica/includ= e/acoutput.h:480:18: note: expanded from macro 'ACPI_FUNCTION_TRACE' > AcpiUtTrace (ACPI_DEBUG_PARAMETERS) > ^ > /usr/home/rpokala/freebsd/clean/base/head/sys/contrib/dev/acpica/includ= e/acoutput.h:402:56: note: expanded from macro 'ACPI_DEBUG_PARAMETERS' > __LINE__, ACPI_GET_FUNCTION_NAME, _AcpiModuleName, _COMPONENT > ^ > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >=20 > That same pattern of errors is noted for lines 321, 362, and 386. >=20 > Please take a look at your earliest convenience. Please try the attached patch. Jung-uk Kim --------------24835374B76989557A313568 Content-Type: text/x-patch; name="atrtc.diff" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="atrtc.diff" Index: sys/x86/isa/atrtc.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- sys/x86/isa/atrtc.c (revision 345013) +++ sys/x86/isa/atrtc.c (working copy) @@ -83,6 +83,11 @@ static int rtc_reg =3D -1; static u_char rtc_statusa =3D RTCSA_DIVIDER | RTCSA_NOPROF; static u_char rtc_statusb =3D RTCSB_24HR; =20 +#ifdef DEV_ACPI +#define _COMPONENT ACPI_TIMER +ACPI_MODULE_NAME("ATRTC") +#endif + /* * RTC support routines */ --------------24835374B76989557A313568-- --ZzUiJPbxQg2h1sVl3OTdwnTXTx7lB2G6m-- --8hW1Bii9Yy2oRgPkvBN6DR9CYkMVJ9WVe Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEl1bqgKaRyqfWXu/CfJ+WJvzb8UYFAlyGplMACgkQfJ+WJvzb 8UZiHwf+KnHjbmgKU62C0QR0b31gWjXKHvvVcuo0gCSwdMGN6f/gn4GHyumJkoWa lExeZFQ8Sqj+Cqz21S63h/0jAwpLuZ+YF5rClaAhvue/kmcP829R9apS45yovESN cRuQ/JLj+b4PFsd611bNU0XMsU7eFKyUFAioxO0YRmFsOKzQh13gdR8oneSECXUQ logKKIhq3GfZWk34cYHaLoj4/prjLIh2f/LyKk6YiyC8dZtoy3U6rYnjAxygbaFB APVWxdJiwkuepbAZOn6prgWvB3w0JqyYOT6h39WdHmEBsiZA4tpnLXlLCkzlMp79 IBfsfaWQc0cRNptRLJzFWsprA44hig== =cFVs -----END PGP SIGNATURE----- --8hW1Bii9Yy2oRgPkvBN6DR9CYkMVJ9WVe--