From owner-freebsd-hackers Tue Mar 19 14:40:57 2002 Delivered-To: freebsd-hackers@freebsd.org Received: from rwcrmhc51.attbi.com (rwcrmhc51.attbi.com [204.127.198.38]) by hub.freebsd.org (Postfix) with ESMTP id 8764A37B425 for ; Tue, 19 Mar 2002 14:40:09 -0800 (PST) Received: from InterJet.elischer.org ([12.232.206.8]) by rwcrmhc51.attbi.com (InterMail vM.4.01.03.27 201-229-121-127-20010626) with ESMTP id <20020319224009.JTSY2626.rwcrmhc51.attbi.com@InterJet.elischer.org>; Tue, 19 Mar 2002 22:40:09 +0000 Received: from localhost (localhost.elischer.org [127.0.0.1]) by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id OAA07687; Tue, 19 Mar 2002 14:38:52 -0800 (PST) Date: Tue, 19 Mar 2002 14:38:52 -0800 (PST) From: Julian Elischer To: Josef Karthauser Cc: Alfred Perlstein , hackers@freebsd.org Subject: Re: usb breakage. In-Reply-To: <20020319213804.GB7786@genius.tao.org.uk> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Tue, 19 Mar 2002, Josef Karthauser wrote: > > > +#if 0 > > Static void > > uhci_dump_ii(uhci_intr_info_t *ii) > > { > > @@ -964,6 +965,7 @@ > > ed->bEndpointAddress, ed->bmAttributes); > > #undef DONE > > } > > +#endif > > I'm not sure why there's two uhci_dump_ii functions defined. I'll get > to the bottom of it (there's one in the NetBSD version). I may have added a dummy one at one stage in order to get LINT to compile.. (I think it was called but didn;t exist when DEBUG was defined) > > > - splx(s) > > + splx(s); > > Ahha! That shouldn't be like that! Feel free to commit this bit. > > Joe > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message