From owner-freebsd-current Tue Aug 25 02:14:33 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id CAA26921 for freebsd-current-outgoing; Tue, 25 Aug 1998 02:14:33 -0700 (PDT) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from nlsystems.com (nlsys.demon.co.uk [158.152.125.33]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id CAA26915 for ; Tue, 25 Aug 1998 02:14:30 -0700 (PDT) (envelope-from dfr@nlsystems.com) Received: from herring.nlsystems.com (herring.nlsystems.com [10.0.0.2]) by nlsystems.com (8.9.1/8.8.5) with SMTP id KAA28248; Tue, 25 Aug 1998 10:13:40 +0100 (BST) Date: Tue, 25 Aug 1998 10:13:40 +0100 (BST) From: Doug Rabson To: "John S. Dyson" cc: current@FreeBSD.ORG Subject: Re: Serious bug in vm_page.h in current In-Reply-To: <199808250841.DAA00455@dyson.iquest.net> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Tue, 25 Aug 1998, John S. Dyson wrote: > Doug Rabson said: > > On Tue, 25 Aug 1998, John S. Dyson wrote: > > > > > > > > PAGE_BUSY is used to set the busy flag, and not the busy > > > bitmask. Attachment contains patch. > > > > I thought of setting the busy flag when I put PAGE_BUSY in but none of the > > places where I changed m->busy++ to PAGE_BUSY(m) set the flag. I'll fix > > it anyway, thanks.. > > > After more careful (and less confused review), your code is correct. The > change in definition isn't that big a deal (only a little confusing when > I was trying to merge some older code in -- and being in a hurry :-)). Likewise, I just read your old patch and understand the confusion. You could set the PG_BUSY flag with PAGE_SET_FLAG(m, PG_BUSY) which uses the new atomic access macros and will be safer on the alpha. -- Doug Rabson Mail: dfr@nlsystems.com Nonlinear Systems Ltd. Phone: +44 181 951 1891 Fax: +44 181 381 1039 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message