From owner-freebsd-gnome@FreeBSD.ORG  Fri Nov  5 20:40:08 2010
Return-Path: <owner-freebsd-gnome@FreeBSD.ORG>
Delivered-To: gnome@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 84F2C1065670
	for <gnome@hub.freebsd.org>; Fri,  5 Nov 2010 20:40:08 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 6DD6A8FC08
	for <gnome@hub.freebsd.org>; Fri,  5 Nov 2010 20:40:08 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id oA5Ke8Su006520
	for <gnome@freefall.freebsd.org>; Fri, 5 Nov 2010 20:40:08 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id oA5Ke8E2006519;
	Fri, 5 Nov 2010 20:40:08 GMT (envelope-from gnats)
Date: Fri, 5 Nov 2010 20:40:08 GMT
Message-Id: <201011052040.oA5Ke8E2006519@freefall.freebsd.org>
To: gnome@FreeBSD.org
From: "Kevin Oberman" <oberman@es.net>
Cc: 
Subject: Re: ports/151725: sysutils/hal: hald fails to start with dbus-1.4 
X-BeenThere: freebsd-gnome@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Kevin Oberman <oberman@es.net>
List-Id: GNOME for FreeBSD -- porting and maintaining
	<freebsd-gnome.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-gnome>,
	<mailto:freebsd-gnome-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-gnome>
List-Post: <mailto:freebsd-gnome@freebsd.org>
List-Help: <mailto:freebsd-gnome-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-gnome>,
	<mailto:freebsd-gnome-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Nov 2010 20:40:08 -0000

The following reply was made to PR ports/151725; it has been noted by GNATS.

From: "Kevin Oberman" <oberman@es.net>
To: Andriy Gapon <avg@freebsd.org>
Cc: gnome@freebsd.org, bug-followup@freebsd.org
Subject: Re: ports/151725: sysutils/hal: hald fails to start with dbus-1.4 
Date: Fri, 05 Nov 2010 13:32:43 -0700

 > Date: Fri, 05 Nov 2010 19:33:08 +0200
 > From: Andriy Gapon <avg@freebsd.org>
 > 
 > on 05/11/2010 19:24 Andriy Gapon said the following:
 > > It looked like the issue was caused by the above write() call after a sufficiently
 > > quick child process had already exited.
 > 
 > The proper patch.
 > 
 > --- hald-runner/runner.c.orig	2010-11-05 19:26:05.673393765 +0200
 > +++ hald-runner/runner.c	2010-11-05 19:26:33.471393058 +0200
 > @@ -281,7 +281,7 @@ run_request_run (run_request *r, DBusCon
 >  	}
 >  	g_free (program_dir);
 > 
 > -	if (r->input) {
 > +	if (r->input && strlen(r->input) > 0) {
 >  		if (write(stdin_v, r->input, strlen(r->input)) != (ssize_t) strlen(r->input))
 >  			printf("Warning: Error while writing r->input (%s) to stdin_v.\n", r->input);
 >  		close(stdin_v);
 
 Looks like you have it! My system now runs hald with the dbus-1.4.0
 without any problems.
 
 Thanks very much, Andriy!
 -- 
 R. Kevin Oberman, Network Engineer
 Energy Sciences Network (ESnet)
 Ernest O. Lawrence Berkeley National Laboratory (Berkeley Lab)
 E-mail: oberman@es.net			Phone: +1 510 486-8634
 Key fingerprint:059B 2DDF 031C 9BA3 14A4  EADA 927D EBB3 987B 3751