From owner-freebsd-testing@FreeBSD.ORG Tue Oct 15 13:54:42 2013 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 3B628DC4 for ; Tue, 15 Oct 2013 13:54:42 +0000 (UTC) (envelope-from julio@meroh.net) Received: from mail-lb0-f174.google.com (mail-lb0-f174.google.com [209.85.217.174]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id BBDF525D8 for ; Tue, 15 Oct 2013 13:54:41 +0000 (UTC) Received: by mail-lb0-f174.google.com with SMTP id w6so6807083lbh.19 for ; Tue, 15 Oct 2013 06:54:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=KoGSJ13VeflQOZCJPXnwF4phMr3KOAPdqyHpE4tcrmk=; b=mnhLg/SwGXawadaU/9dPHoO9GB7TwzmI6dJMGXnL1sfi165gv5p1Uoyc+ApwPSUBfv amCqL7+wMsR4tkjBBtH32rdHNTWtIimoaQZUX8oyunhr17XnnF/VU7T4UK+Oyh6LFD/7 qpoyQFng2e0Z1ixfuks3blzKzQP13UMM9dqBHy+La02J0bDSt5qlpGWOy99QCevBbjMj Yj7pA+GtGkAeDM4s3Tke7Z1E3Awxd/kYb0nC9yX+RgxDRRKdzVDQhpaN4cEYBEJu7EHA G2EtFp4vpRQnk/ZNMT6D0iNRZNcGKB17rx4hbAHVowu520UXKRy82Pm/94Vt/shyjMyR +gvA== X-Gm-Message-State: ALoCoQmnntlVU0dRAy5/aM52txmbB3Nbn6Sfs7HF+rwyFnDnyboQz188dVUGPdzcnPO31XRtAE1n X-Received: by 10.112.52.225 with SMTP id w1mr6890488lbo.31.1381845274053; Tue, 15 Oct 2013 06:54:34 -0700 (PDT) MIME-Version: 1.0 Received: by 10.112.132.135 with HTTP; Tue, 15 Oct 2013 06:54:14 -0700 (PDT) X-Originating-IP: [2620:0:1003:1007:f060:8d4:3979:1541] In-Reply-To: <20131015062139.DAD595807E@chaos.jnpr.net> References: <20131015062139.DAD595807E@chaos.jnpr.net> From: Julio Merino Date: Tue, 15 Oct 2013 09:54:14 -0400 Message-ID: Subject: Re: Refactoring of *.test.mk To: "Simon J. Gerraty" Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-testing@freebsd.org, Rui Paulo , Garrett Cooper X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Oct 2013 13:54:42 -0000 On Tue, Oct 15, 2013 at 2:21 AM, Simon J. Gerraty wrote: > Thanks Julio, > > looks good. Thanks for the reviews Simon and Rui. > One nit; in hook-atf-run.diff and hook-kyua.diff I see: [...] > ATF_BUILD_CC?= ${DESTDIR}/usr/bin/cc > .. > TESTS_ENV+= ATF_BUILD_CC=${ATF_BUILD_CC} > .. OK, I've done this. And, at the same time, improved the way TESTS_ENV is constructed by leaving the atf-specific bits in atf.test.mk and moving the path handling to bsd.test.mk. PTAL. I suspect that with 10 branched, we don't need approval from re@ for submission at this point; is that correct? That said, I think it's worth to merge this into 10 (now or after release, doesn't matter much). Given that this touches yet-unused files, it shouldn't be a major concern for re@. The reason for merging into 10 is that it'd be nice if any future tests written in HEAD for regressions encountered in 10 could be pulled up into the branch with ease along the actual fixes. Cheers, -- Julio Merino / @jmmv