Date: Sun, 26 Jun 2005 18:17:14 +0200 From: Max Laier <max@love2party.net> To: Sascha Luck <sascha@c4inet.net> Cc: freebsd-pf@freebsd.org Subject: Re: pfsync / 6-CURRENT-amd64 Message-ID: <200506261817.21799.max@love2party.net> In-Reply-To: <20050626155248.GB46138@saoirse.c4inet.net> References: <20050626020825.GA45376@saoirse.c4inet.net> <200506261648.38553.max@love2party.net> <20050626155248.GB46138@saoirse.c4inet.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--nextPart2196370.YaKSGLIlAi Content-Type: multipart/mixed; boundary="Boundary-01=_MUtvCG+GhVzFdtp" Content-Transfer-Encoding: 7bit Content-Disposition: inline --Boundary-01=_MUtvCG+GhVzFdtp Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Sunday 26 June 2005 17:52, Sascha Luck wrote: > On Sun, Jun 26, 2005 at 04:48:31PM +0200, Max Laier wrote: > > Can you verify that it breaks with if_pfsync.c,rev. 1.16? Unfortunatel= y, > > rev. 1.17 happend just one hour after 1.16 and also includes serious > > changes to pfsync. > > I've rebuilt both with 1.16 and there now is pfsync traffic. Yep, and sta= te > tables are being synchronised again too. :) Can you try the attached patch, please? I forgot to initialize ifq_maxlen,= it=20 seems :-\ =2D-=20 /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News --Boundary-01=_MUtvCG+GhVzFdtp Content-Type: text/x-diff; charset="iso-8859-1"; name="fix_pfsync.diff" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="fix_pfsync.diff" Index: if_pfsync.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /usr/store/mlaier/fcvs/src/sys/contrib/pf/net/if_pfsync.c,v retrieving revision 1.18 diff -u -r1.18 if_pfsync.c =2D-- if_pfsync.c 12 Jun 2005 16:46:20 -0000 1.18 +++ if_pfsync.c 26 Jun 2005 16:15:49 -0000 @@ -224,6 +224,7 @@ callout_init(&sc->sc_bulk_tmo, NET_CALLOUT_MPSAFE); callout_init(&sc->sc_bulkfail_tmo, NET_CALLOUT_MPSAFE); callout_init(&sc->sc_send_tmo, NET_CALLOUT_MPSAFE); + &sc->sc_ifq.ifq_maxlen =3D 64; mtx_init(&sc->sc_ifq.ifq_mtx, ifp->if_xname, "pfsync send queue", MTX_DEF); if_attach(ifp); @@ -1797,7 +1798,7 @@ =20 pfsyncstats.pfsyncs_opackets++; #ifdef __FreeBSD__ =2D if (IF_HANDOFF(&sc->sc_ifq, m, NULL)) + if (!IF_HANDOFF(&sc->sc_ifq, m, NULL)) pfsyncstats.pfsyncs_oerrors++; callout_reset(&sc->sc_send_tmo, 1, pfsync_senddef, sc); #else --Boundary-01=_MUtvCG+GhVzFdtp-- --nextPart2196370.YaKSGLIlAi Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iD8DBQBCvtURXyyEoT62BG0RAt8mAJ9EwYVUhDwEwl8Lj8rQdOs/xMLdHACdGaz/ QWXKxtK5l0gMVljPdPfvKsY= =uNb1 -----END PGP SIGNATURE----- --nextPart2196370.YaKSGLIlAi--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200506261817.21799.max>