From owner-svn-src-all@freebsd.org Fri Jan 20 06:29:53 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AAACECB9E59; Fri, 20 Jan 2017 06:29:53 +0000 (UTC) (envelope-from antoine.brodin.freebsd@gmail.com) Received: from mail-it0-x244.google.com (mail-it0-x244.google.com [IPv6:2607:f8b0:4001:c0b::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 741431717; Fri, 20 Jan 2017 06:29:53 +0000 (UTC) (envelope-from antoine.brodin.freebsd@gmail.com) Received: by mail-it0-x244.google.com with SMTP id e137so1953649itc.0; Thu, 19 Jan 2017 22:29:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=GWCy4sLcOg3U5r2wNHfXR7anBHpMaN9lybgeMkd0ZgA=; b=kqHrt9B3d/T4NaWyXdspEVhtxzHmBoxdBPjuz21sioBpuUkh3pii1bpc+Xs/MbZEnL T3sKpu+p6sED0/dgQNgWQbA9u9q3Cb58/c8fiiYDagDaYEnjFnARup4FmoFRj30Hbl4t robUaDK45DWacPipAhmDdYfv0KmR6gnuHR/y5rJlp93Dn9ctWzQbxRfTvOqled50FnNO KDq9yFS4sQQ7vyojbvbMu+SDxmhwKdX1T7nMlij4y2y/D3Tl3RrFLPrjjPSpSfDzUmx0 iZedq5/mSwyOjGOVN6kdXuvxWBklOlbB6g+FIQ+eae4FDqMUn+nxLb5ZRM7hLH7PND/n 7PfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=GWCy4sLcOg3U5r2wNHfXR7anBHpMaN9lybgeMkd0ZgA=; b=Z1DO8bIWR8i6caQIciG4yFRz2grotP2A2N95fov9rNYsVV7fFcipkqkjvl9ZnEDp9Z +FsAWYZ4ZnHYNEY/sl+VWK56X+qiEa9TrfQwsmKtBs4U7iHE5gXBJ4zxaOg63ubeJt2k WUzvhaElKMUJCcSEc3ueezvHtp0wpCEcYT6c9XltwWiKx76eU7gafHWCsokUcFqZLHMX 272gC0e8JPHey1y0CAFHFExNO4JZzn+8Dt2hN8r+7HDQNxd5rwF0zgRjgAOj4lF0vUEB xdTto1yphmOeLkP24p2Q6pWmmcAZw57iEyFq0zDvOvh97kfkowtRw8gR5tvaWZ74gHJa /qpw== X-Gm-Message-State: AIkVDXLBvjEPq3wp9eW+86dwMZl1FH0rMqxA1qKzgWbolg/spl/WNj/TyYf0cjtmDo/o4RL+3rfsYuI2uqBgIg== X-Received: by 10.36.40.139 with SMTP id h133mr2174106ith.40.1484893792682; Thu, 19 Jan 2017 22:29:52 -0800 (PST) MIME-Version: 1.0 Sender: antoine.brodin.freebsd@gmail.com Received: by 10.107.205.142 with HTTP; Thu, 19 Jan 2017 22:29:52 -0800 (PST) In-Reply-To: <201701190801.v0J81ZG9008267@repo.freebsd.org> References: <201701190801.v0J81ZG9008267@repo.freebsd.org> From: Antoine Brodin Date: Fri, 20 Jan 2017 07:29:52 +0100 X-Google-Sender-Auth: qjXz9JKboAGyxKL30Dxn8dmkN5w Message-ID: Subject: Re: svn commit: r312404 - head/usr.bin/sed To: Xin LI Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jan 2017 06:29:53 -0000 On Thu, Jan 19, 2017 at 9:01 AM, Xin LI wrote: > Author: delphij > Date: Thu Jan 19 08:01:35 2017 > New Revision: 312404 > URL: https://svnweb.freebsd.org/changeset/base/312404 > > Log: > Use S_ISREG instead of manual & (also it's better to compare the > result from & and the pattern instead of just assuming it's one bit > value). > > Pointed out by Tianjie Mao . > > MFC after: 2 weeks > Differential Revision: https://reviews.freebsd.org/D4827 Hi, sed -i no longer works on symlinks which breaks lots of ports. Please revert and request an exp-run. Cheers, Antoine