From owner-freebsd-current Mon Nov 30 23:26:57 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id XAA25126 for freebsd-current-outgoing; Mon, 30 Nov 1998 23:26:57 -0800 (PST) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from apollo.backplane.com (apollo.backplane.com [209.157.86.2]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id XAA25118 for ; Mon, 30 Nov 1998 23:26:54 -0800 (PST) (envelope-from dillon@apollo.backplane.com) Received: (from dillon@localhost) by apollo.backplane.com (8.9.1/8.9.1) id XAA03791; Mon, 30 Nov 1998 23:26:26 -0800 (PST) (envelope-from dillon) Date: Mon, 30 Nov 1998 23:26:26 -0800 (PST) From: Matthew Dillon Message-Id: <199812010726.XAA03791@apollo.backplane.com> To: David Greenman Cc: freebsd-current@FreeBSD.ORG Subject: Re: D.O.S. attack protection enhancements commit (ICMP_BANDLIM) References: <199812010714.XAA26714@root.com> Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG :> testing of the same patch to our -current tree). :> :> The commit I want to commit is just the ICMP_BANDLIM section. I am : : The only comment I have at the moment is that the patches need a little :KNF work. The mixing of indentation amounts within a function is particularly :annoying and makes the code difficult to read. Indents should be tabs, with Don't worry about that... I'll clean that up in an official commit. I'm not keen on 8-character indents, but I try to commit things that follow the tone of the surrounding source. :general scheme implemented perhaps inside the ipfw framework would be more :appropriate. I also generally like to avoid compile time options for things :like this, but I"m sympathetic for performance reducing enhancements. : :-DG I figure we would make it the default in 6 months to a year, but we should have it optioned initially so people can play with it and also because it defaults to enabled when optioned-in, which I think is important. -Matt : :David Greenman :Co-founder/Principal Architect, The FreeBSD Project : :To Unsubscribe: send mail to majordomo@FreeBSD.org :with "unsubscribe freebsd-current" in the body of the message : Matthew Dillon Engineering, HiWay Technologies, Inc. & BEST Internet Communications & God knows what else. (Please include original email in any response) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message